renderer: kit pillar grounding — seat bounds min.y on floor (r6, #83)#1685
Conversation
PlacePillar's y-term (pivotOffset.y - b1.min.y) double-counts the bounds centre for base-pivot meshes: Synty pillars (pivot at base, centre.y=+2.0 after scaling) landed at pos.y=-1.98 with world bounds -1.99..2.01 — half the column underground, reading as a short stub despite achieved size (1.20, 4.00, 1.20) being exactly on target. Fix: ground on min.y alone (position.y - b1.min.y). Box-verified live: all 4 pillars now minY=0.00 maxY=4.00; capture kit_crypt_20260722T1538Z shows full-height columns. Part of #83 / #84 navigation-truth spike.
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 50 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
qa/registration_score.py refuses non-contract sizes (its projection is defined in the 1344x768 frame); the 2560x1600 review render alone could not be scored. One capture op now writes both files.
1 participant
One-line grounding fix in
PlacePillar, box-validated before commit.Bug (measured on the box, r5 build): achieved pillar world size was exactly on target (1.20, 4.00, 1.20) — the r5 measured-multiplier works — but every pillar sat at
pos.y=-1.98with world bounds-1.99..+2.01: half the column underground, rendering as a short stub.Root cause: the seating formula
pivotOffset.y - b1.min.ydouble-counts the bounds centre for base-pivot meshes (Synty pillar pivot is at its base → centre.y=+2.0 after scaling → pos.y=-2.0). The tomb reads correctly only because its pivot is centred.Fix: ground on
min.yalone:position.y - b1.min.y.Box verification (same session): post-fix probe reports all 4 pillars
minY=0.00 maxY=4.00 sizeY=4.00; capturekit_crypt_20260722T1538Zshows four full-height brick columns at the quadrant positions. Round log on #83.