Skip to content

renderer: kit pillar grounding — seat bounds min.y on floor (r6, #83) #1685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
100yenadmin merged 2 commits into from
Jul 22, 2026
Merged

renderer: kit pillar grounding — seat bounds min.y on floor (r6, #83) #1685

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be5806e
renderer: kit pillar grounding — seat bounds min.y on the floor (r6)
100yenadmin Jul 22, 2026
2cd3113
renderer: CaptureRoom also emits the 1344x768 contract frame (r6)
100yenadmin Jul 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions extensions/renderers/unity/scripts/build_room_kit.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,19 +381,24 @@ public static void CaptureRoom()
foreach (var ll in UnityEngine.Object.FindObjectsByType<Light>(FindObjectsSortMode.None))
{ if (ll == null || ll.transform.IsChildOf(root.transform)) continue; if (ll.enabled) { ll.enabled = false; disLights.Add(ll); } }

string outPath = null;
string outPath = null; string contractPath = null;
try
{
string stamp = DateTime.UtcNow.ToString("yyyyMMdd'T'HHmm'Z'", CultureInfo.InvariantCulture);
outPath = Path.Combine(CaptureDir(), $"kit_{roomId}_{stamp}.png");
RenderToPng(cam, W, H, outPath);
// r6: ALSO emit the 1344x768 CONTRACT frame — qa/registration_score.py refuses any other
// size (its projection math is defined in that frame), so every capture yields both.
contractPath = Path.Combine(CaptureDir(), $"kit_{roomId}_{stamp}_contract.png");
SetupContractCamera(cam, cols, rows, camFit, 1344f / 768f);
RenderToPng(cam, 1344, 768, contractPath);
}
finally
{
foreach (var rr in hidRends) if (rr != null) rr.enabled = true;
foreach (var ll in disLights) if (ll != null) ll.enabled = true;
}
Debug.Log($"[KitRoom] captured {W}x{H} → {outPath}");
Debug.Log($"[KitRoom] captured {W}x{H} → {outPath} + contract 1344x768 → {contractPath}");
}

// ════════════════════════════════════════════════════════════════════════════════════════════════
Expand Down Expand Up @@ -549,7 +554,9 @@ static GameObject PlacePillar(GameObject prefab, string name, GameObject parent,
Debug.LogWarning($"[KitRoom] ⚠⚠ pillar '{name}' achieved world=({b1.size.x:F2},{b1.size.y:F2},{b1.size.z:F2}) " +
$"is OFF target ({PILLAR_TGT_XZ:F1},{PILLAR_TGT_H:F1},{PILLAR_TGT_XZ:F1}) by >10% — check prefab bounds/pivot.");
Vector3 pivotOffset = inst.transform.position - b1.center;
inst.transform.position = new Vector3(center.x + pivotOffset.x, pivotOffset.y - b1.min.y, center.z + pivotOffset.z);
// r6: ground on min.y alone — the pivotOffset.y term double-counts the bounds centre for
// base-pivot meshes (measured: pillars sat at pos.y=-1.98, bounds -1.99..2.01, half underground).
inst.transform.position = new Vector3(center.x + pivotOffset.x, inst.transform.position.y - b1.min.y, center.z + pivotOffset.z);
FixMaterials(inst, false, ref matFix, force: true); // r5: pillars shipped grey → force stone/brick
return inst;
}
Expand Down
Loading