PanelClone: Don't animate while in fullscreen #1927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should this instead be any time a dock or panel is hidden we don't animate? I've seen similar glitches with maximized apps for example |
|
Hmm yeah I know what you mean but I think it's a different problem. Because if windows are maximized and we hit the barrier we actually want the dock to show up but for some reason it won't causing the clone to just hide again. Whereas in fullscreen it's wanted behavior that the dock doesn't show so we just don't animate. |
danirabbit
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While in fullscreen docks are hidden so if we animate we just get the clone flying in and immediately disappearing