Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PanelClone: Don't animate while in fullscreen #1927

Merged
merged 3 commits into from
May 28, 2024
Merged

PanelClone: Don't animate while in fullscreen #1927

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3ce236a
PanelClone: Don't animate while in fullscreen
leolost2605 May 28, 2024
0b8138d
Merge branch 'master' into leolost/dont-animate-in-fullscreen
danirabbit May 28, 2024
cb6ffd6
Merge branch 'master' into leolost/dont-animate-in-fullscreen
danirabbit May 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/ShellClients/PanelClone.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,12 @@ public class Gala.PanelClone : Object {
}
}

private int get_animation_duration () {
var fullscreen = wm.get_display ().get_monitor_in_fullscreen (panel.window.get_monitor ());
var should_animate = wm.enable_animations && !wm.workspace_view.is_opened () && !fullscreen;
return should_animate ? ANIMATION_DURATION : 0;
}

private void hide () {
if (panel_hidden) {
return;
Expand All @@ -120,7 +126,7 @@ public class Gala.PanelClone : Object {

clone.save_easing_state ();
clone.set_easing_mode (Clutter.AnimationMode.EASE_OUT_QUAD);
clone.set_easing_duration (wm.enable_animations && !wm.workspace_view.is_opened () ? ANIMATION_DURATION : 0);
clone.set_easing_duration (get_animation_duration ());
clone.y = calculate_clone_y (true);
clone.restore_easing_state ();
}
Expand All @@ -130,7 +136,7 @@ public class Gala.PanelClone : Object {
return;
}

var animation_duration = wm.enable_animations && !wm.workspace_view.is_opened () ? ANIMATION_DURATION : 0;
var animation_duration = get_animation_duration ();

clone.save_easing_state ();
clone.set_easing_mode (Clutter.AnimationMode.EASE_OUT_QUAD);
Expand Down
Loading