Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make helpers unambiguious with parens aka subexpressions #509

Merged
merged 5 commits into from
Dec 4, 2023

Conversation

lolmaus
Copy link
Contributor

@lolmaus lolmaus commented Dec 4, 2023

Supercedes #507.

Quite a lot going on, please review by commit. 🙏

@lolmaus lolmaus force-pushed the helper-subexpressions3 branch from d40f81d to cdb8e20 Compare December 4, 2023 17:18
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 🎉

@lolmaus lolmaus marked this pull request as ready for review December 4, 2023 17:25
@mansona mansona merged commit 1f8aa4f into ember-codemods:master Dec 4, 2023
4 checks passed
@mansona mansona changed the title Make helpers unambiguious with parens aka subexpressions (take 2) Make helpers unambiguious with parens aka subexpressions Dec 4, 2023
@github-actions github-actions bot mentioned this pull request Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants