Fix: dynamic modifier tag not cleared when instance becomes undefined by Copilot · Pull Request #21377 · emberjs/ember.js

Copilot · 2026-05-06T22:25:47Z

When a dynamic modifier conditionally becomes undefined (e.g. {{(if cond myModifier)}}), the UpdateDynamicModifierOpcode correctly nulled this.instance but left this.tag pointing at the destroyed instance's tag. On the next render, if that stale tag was invalidated by an arg change, the else if branch fired scheduleUpdateModifier(instance!) with instance === undefined, producing:

Cannot destructure property 'manager' of '.for' as it is undefined

The error is especially triggered when arguments are passed to a component that uses a modifier — the arg change invalidates the stale tag while the modifier is disabled.

Changes

packages/@glimmer/runtime/lib/compiled/opcodes/dom.ts — In UpdateDynamicModifierOpcode.evaluate(), reset both the local tag variable and this.tag to null when newInstance is undefined:

if (newInstance !== undefined) {
  // ... set up new instance, update tag
  this.tag = tag;
  vm.env.scheduleInstallModifier(newInstance);
} else {
  tag = null;       // was missing
  this.tag = null;  // was missing
}

packages/@glimmer-workspace/integration-tests/test/modifiers/dynamic-modifiers-test.ts — Adds a regression test covering: install modifier → disable via if → change args → re-enable.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

accounts.google.com
- Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --ignore-certificate-errors --use-angle=swiftshader-webgl --mute-audio --ignore-certificate-errors --crashpad-handler-pid=4936 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/testem-6392411320686-6hBVmX --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,9827928193251718403,1265053761173172249,262144 --disable-features=PaintHolding --variations-seed-version (dns block)
- Triggering command: /opt/google/chrome/chrome /usr/bin/google-chrome --no-sandbox --headless --disable-dev-shm-usage --disable-software-rasterizer --mute-audio --remote-debugging-port=0 --window-size=1440,900 --user-data-dir=/tmp/testem-6392411320686-6hBVmX --no-default-browser-check --no-first-run --ignore-certificate-errors --test-type --disable-renderer-REDACTEDing --disable-REDACTED-timer-throttling REDACTED (dns block)
- Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --ignore-certificate-errors --use-angle=swiftshader-webgl --mute-audio --ignore-certificate-errors --crashpad-handler-pid=5696 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/testem-6924272276592-s2Io6S --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,7409941703946872075,11366128499208713936,262144 --disable-features=PaintHolding --variations-seed-version (dns block)
android.clients.google.com
- Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --ignore-certificate-errors --use-angle=swiftshader-webgl --mute-audio --ignore-certificate-errors --crashpad-handler-pid=4936 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/testem-6392411320686-6hBVmX --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,9827928193251718403,1265053761173172249,262144 --disable-features=PaintHolding --variations-seed-version (dns block)
- Triggering command: /opt/google/chrome/chrome /usr/bin/google-chrome --no-sandbox --headless --disable-dev-shm-usage --disable-software-rasterizer --mute-audio --remote-debugging-port=0 --window-size=1440,900 --user-data-dir=/tmp/testem-6392411320686-6hBVmX --no-default-browser-check --no-first-run --ignore-certificate-errors --test-type --disable-renderer-REDACTEDing --disable-REDACTED-timer-throttling REDACTED (dns block)
- Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --ignore-certificate-errors --use-angle=swiftshader-webgl --mute-audio --ignore-certificate-errors --crashpad-handler-pid=5696 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/testem-6924272276592-s2Io6S --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,7409941703946872075,11366128499208713936,262144 --disable-features=PaintHolding --variations-seed-version (dns block)
clients2.google.com
- Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --ignore-certificate-errors --use-angle=swiftshader-webgl --mute-audio --ignore-certificate-errors --crashpad-handler-pid=4936 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/testem-6392411320686-6hBVmX --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,9827928193251718403,1265053761173172249,262144 --disable-features=PaintHolding --variations-seed-version (dns block)
- Triggering command: /opt/google/chrome/chrome /usr/bin/google-chrome --no-sandbox --headless --disable-dev-shm-usage --disable-software-rasterizer --mute-audio --remote-debugging-port=0 --window-size=1440,900 --user-data-dir=/tmp/testem-6392411320686-6hBVmX --no-default-browser-check --no-first-run --ignore-certificate-errors --test-type --disable-renderer-REDACTEDing --disable-REDACTED-timer-throttling REDACTED (dns block)
- Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --ignore-certificate-errors --use-angle=swiftshader-webgl --mute-audio --ignore-certificate-errors --crashpad-handler-pid=5696 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/testem-6924272276592-s2Io6S --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,7409941703946872075,11366128499208713936,262144 --disable-features=PaintHolding --variations-seed-version (dns block)
clientservices.googleapis.com
- Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --ignore-certificate-errors --use-angle=swiftshader-webgl --mute-audio --ignore-certificate-errors --crashpad-handler-pid=4936 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/testem-6392411320686-6hBVmX --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,9827928193251718403,1265053761173172249,262144 --disable-features=PaintHolding --variations-seed-version (dns block)
- Triggering command: /opt/google/chrome/chrome /usr/bin/google-chrome --no-sandbox --headless --disable-dev-shm-usage --disable-software-rasterizer --mute-audio --remote-debugging-port=0 --window-size=1440,900 --user-data-dir=/tmp/testem-6392411320686-6hBVmX --no-default-browser-check --no-first-run --ignore-certificate-errors --test-type --disable-renderer-REDACTEDing --disable-REDACTED-timer-throttling REDACTED (dns block)
- Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --ignore-certificate-errors --use-angle=swiftshader-webgl --mute-audio --ignore-certificate-errors --crashpad-handler-pid=5696 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/testem-6924272276592-s2Io6S --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,7409941703946872075,11366128499208713936,262144 --disable-features=PaintHolding --variations-seed-version (dns block)
content-autofill.googleapis.com
- Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --ignore-certificate-errors --use-angle=swiftshader-webgl --mute-audio --ignore-certificate-errors --crashpad-handler-pid=5860 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/testem-7065270613233-Zs8Gkg --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,8031331439931817784,9817379153750705194,262144 --disable-features=PaintHolding --variations-seed-version (dns block)
- Triggering command: /opt/google/chrome/chrome /usr/bin/google-chrome --no-sandbox --headless --disable-dev-shm-usage --disable-software-rasterizer --mute-audio --remote-debugging-port=0 --window-size=1440,900 --user-data-dir=/tmp/testem-7065270613233-Zs8Gkg --no-default-browser-check --no-first-run --ignore-certificate-errors --test-type --disable-renderer-REDACTEDing --disable-REDACTED-timer-throttling REDACTED (dns block)
- Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --ignore-certificate-errors --use-angle=swiftshader-webgl --mute-audio --ignore-certificate-errors --crashpad-handler-pid=6022 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/testem-7177259096120-tL13t9 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,13198373564918574748,12643688462969006057,262144 --disable-features=PaintHolding --variations-seed-version (dns block)
foo.bar
- Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --ignore-certificate-errors --use-angle=swiftshader-webgl --mute-audio --ignore-certificate-errors --crashpad-handler-pid=5860 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/testem-7065270613233-Zs8Gkg --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,8031331439931817784,9817379153750705194,262144 --disable-features=PaintHolding --variations-seed-version (dns block)
- Triggering command: /opt/google/chrome/chrome /usr/bin/google-chrome --no-sandbox --headless --disable-dev-shm-usage --disable-software-rasterizer --mute-audio --remote-debugging-port=0 --window-size=1440,900 --user-data-dir=/tmp/testem-7065270613233-Zs8Gkg --no-default-browser-check --no-first-run --ignore-certificate-errors --test-type --disable-renderer-REDACTEDing --disable-REDACTED-timer-throttling REDACTED (dns block)
- Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --ignore-certificate-errors --use-angle=swiftshader-webgl --mute-audio --ignore-certificate-errors --crashpad-handler-pid=6022 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/testem-7177259096120-tL13t9 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,13198373564918574748,12643688462969006057,262144 --disable-features=PaintHolding --variations-seed-version (dns block)
optimizationguide-pa.googleapis.com
- Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --ignore-certificate-errors --use-angle=swiftshader-webgl --mute-audio --ignore-certificate-errors --crashpad-handler-pid=4936 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/testem-6392411320686-6hBVmX --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,9827928193251718403,1265053761173172249,262144 --disable-features=PaintHolding --variations-seed-version (dns block)
- Triggering command: /opt/google/chrome/chrome /usr/bin/google-chrome --no-sandbox --headless --disable-dev-shm-usage --disable-software-rasterizer --mute-audio --remote-debugging-port=0 --window-size=1440,900 --user-data-dir=/tmp/testem-6392411320686-6hBVmX --no-default-browser-check --no-first-run --ignore-certificate-errors --test-type --disable-renderer-REDACTEDing --disable-REDACTED-timer-throttling REDACTED (dns block)
- Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --ignore-certificate-errors --use-angle=swiftshader-webgl --mute-audio --ignore-certificate-errors --crashpad-handler-pid=5696 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/testem-6924272276592-s2Io6S --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,7409941703946872075,11366128499208713936,262144 --disable-features=PaintHolding --variations-seed-version (dns block)
redirector.gvt1.com
- Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --ignore-certificate-errors --use-angle=swiftshader-webgl --mute-audio --ignore-certificate-errors --crashpad-handler-pid=4936 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/testem-6392411320686-6hBVmX --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,9827928193251718403,1265053761173172249,262144 --disable-features=PaintHolding --variations-seed-version (dns block)
- Triggering command: /opt/google/chrome/chrome /usr/bin/google-chrome --no-sandbox --headless --disable-dev-shm-usage --disable-software-rasterizer --mute-audio --remote-debugging-port=0 --window-size=1440,900 --user-data-dir=/tmp/testem-6392411320686-6hBVmX --no-default-browser-check --no-first-run --ignore-certificate-errors --test-type --disable-renderer-REDACTEDing --disable-REDACTED-timer-throttling REDACTED (dns block)
- Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --ignore-certificate-errors --use-angle=swiftshader-webgl --mute-audio --ignore-certificate-errors --crashpad-handler-pid=5696 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/testem-6924272276592-s2Io6S --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,7409941703946872075,11366128499208713936,262144 --disable-features=PaintHolding --variations-seed-version (dns block)
safebrowsing.googleapis.com
- Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --ignore-certificate-errors --use-angle=swiftshader-webgl --mute-audio --ignore-certificate-errors --crashpad-handler-pid=5696 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/testem-6924272276592-s2Io6S --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,7409941703946872075,11366128499208713936,262144 --disable-features=PaintHolding --variations-seed-version (dns block)
- Triggering command: /opt/google/chrome/chrome /usr/bin/google-chrome --no-sandbox --headless --disable-dev-shm-usage --disable-software-rasterizer --mute-audio --remote-debugging-port=0 --window-size=1440,900 --user-data-dir=/tmp/testem-6924272276592-s2Io6S --no-default-browser-check --no-first-run --ignore-certificate-errors --test-type --disable-renderer-REDACTEDing --disable-REDACTED-timer-throttling REDACTED (dns block)
- Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --ignore-certificate-errors --use-angle=swiftshader-webgl --mute-audio --ignore-certificate-errors --crashpad-handler-pid=6022 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/testem-7177259096120-tL13t9 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,13198373564918574748,12643688462969006057,262144 --disable-features=PaintHolding --variations-seed-version (dns block)
safebrowsingohttpgateway.googleapis.com
- Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --ignore-certificate-errors --use-angle=swiftshader-webgl --mute-audio --ignore-certificate-errors --crashpad-handler-pid=4936 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/testem-6392411320686-6hBVmX --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,9827928193251718403,1265053761173172249,262144 --disable-features=PaintHolding --variations-seed-version (dns block)
- Triggering command: /opt/google/chrome/chrome /usr/bin/google-chrome --no-sandbox --headless --disable-dev-shm-usage --disable-software-rasterizer --mute-audio --remote-debugging-port=0 --window-size=1440,900 --user-data-dir=/tmp/testem-6392411320686-6hBVmX --no-default-browser-check --no-first-run --ignore-certificate-errors --test-type --disable-renderer-REDACTEDing --disable-REDACTED-timer-throttling REDACTED (dns block)
- Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --ignore-certificate-errors --use-angle=swiftshader-webgl --mute-audio --ignore-certificate-errors --crashpad-handler-pid=5696 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/testem-6924272276592-s2Io6S --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,7409941703946872075,11366128499208713936,262144 --disable-features=PaintHolding --variations-seed-version (dns block)
update.googleapis.com
- Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --ignore-certificate-errors --use-angle=swiftshader-webgl --mute-audio --ignore-certificate-errors --crashpad-handler-pid=4936 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/testem-6392411320686-6hBVmX --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,9827928193251718403,1265053761173172249,262144 --disable-features=PaintHolding --variations-seed-version (dns block)
- Triggering command: /opt/google/chrome/chrome /usr/bin/google-chrome --no-sandbox --headless --disable-dev-shm-usage --disable-software-rasterizer --mute-audio --remote-debugging-port=0 --window-size=1440,900 --user-data-dir=/tmp/testem-6392411320686-6hBVmX --no-default-browser-check --no-first-run --ignore-certificate-errors --test-type --disable-renderer-REDACTEDing --disable-REDACTED-timer-throttling REDACTED (dns block)
- Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --ignore-certificate-errors --use-angle=swiftshader-webgl --mute-audio --ignore-certificate-errors --crashpad-handler-pid=5696 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/testem-6924272276592-s2Io6S --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,7409941703946872075,11366128499208713936,262144 --disable-features=PaintHolding --variations-seed-version (dns block)
www.google.com
- Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --ignore-certificate-errors --use-angle=swiftshader-webgl --mute-audio --ignore-certificate-errors --crashpad-handler-pid=4936 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/testem-6392411320686-6hBVmX --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,9827928193251718403,1265053761173172249,262144 --disable-features=PaintHolding --variations-seed-version (dns block)
- Triggering command: /opt/google/chrome/chrome /usr/bin/google-chrome --no-sandbox --headless --disable-dev-shm-usage --disable-software-rasterizer --mute-audio --remote-debugging-port=0 --window-size=1440,900 --user-data-dir=/tmp/testem-6392411320686-6hBVmX --no-default-browser-check --no-first-run --ignore-certificate-errors --test-type --disable-renderer-REDACTEDing --disable-REDACTED-timer-throttling REDACTED (dns block)
- Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --ignore-certificate-errors --use-angle=swiftshader-webgl --mute-audio --ignore-certificate-errors --crashpad-handler-pid=5696 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/testem-6924272276592-s2Io6S --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,7409941703946872075,11366128499208713936,262144 --disable-features=PaintHolding --variations-seed-version (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

…mes undefined Agent-Logs-Url: https://github.com/emberjs/ember.js/sessions/c1b037b4-d2f5-447c-b42a-5f5cb9387234 Co-authored-by: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com>

github-actions · 2026-05-07T04:17:10Z

📊 Size report

Tarball size — 1.2 MB → 1.2 MB

dist/dev `0.01%↑`

File	Before (Size / Brotli)	After (Size / Brotli)
`./packages/shared-chunks/cache-{hash}.js`	`697 B` / `258 B`	^2,460%↑`17.9 kB` / ^1,760%↑`4.8 kB`
`./packages/shared-chunks/untouchable-{hash}.js`	`62.6 kB` / `12.2 kB`	^0.3%↑`62.8 kB` / ^0.2%↑`12.3 kB`
Total _{(Includes all files)}	`2 MB` / `484.8 kB`	^0.01%↑`2 MB` / ^0.02%↑`484.9 kB`

dist/prod `0.01%↑`

File	Before (Size / Brotli)	After (Size / Brotli)
`./packages/shared-chunks/debug-{hash}.js`	`58.4 kB` / `11.3 kB`	^0.4%↑`58.6 kB` / ^0.4%↑`11.4 kB`
Total _{(Includes all files)}	`1.8 MB` / `444.1 kB`	^0.01%↑`1.8 MB` / ^0%↑`444.1 kB`

smoke-tests/v2-app-hello-world-template/dist `0.01%↑`

File	Before (Size / Brotli)	After (Size / Brotli)
Total _{(Includes all files)}	`243.6 kB` / `66.8 kB`	^0.01%↑`243.6 kB` / ^0.05%↑`66.8 kB`

_{🤖 This report was automatically generated by wyvox/pkg-size}

Initial plan

be71033

Copilot AI assigned Copilot and NullVoxPopuli May 6, 2026

Copilot started work on behalf of NullVoxPopuli May 6, 2026 22:25 View session

Copilot AI linked an issue May 6, 2026 that may be closed by this pull request

Cannot destructure property 'manager' of '.for' as it is undefined #20979

Open

Fix UpdateDynamicModifierOpcode: reset tag to null when instance beco…

d9dae91

…mes undefined Agent-Logs-Url: https://github.com/emberjs/ember.js/sessions/c1b037b4-d2f5-447c-b42a-5f5cb9387234 Co-authored-by: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Fix cannot destructure property 'manager' of '.for' as it is undefined~~ Fix: dynamic modifier tag not cleared when instance becomes undefined May 6, 2026

Copilot finished work on behalf of NullVoxPopuli May 6, 2026 22:58

Copilot AI requested a review from NullVoxPopuli May 6, 2026 22:58

NullVoxPopuli mentioned this pull request May 7, 2026

Test out: https://github.com/emberjs/ember.js/pull/21377 NullVoxPopuli/limber#2163

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix: dynamic modifier tag not cleared when instance becomes undefined#21377

Fix: dynamic modifier tag not cleared when instance becomes undefined#21377
Copilot wants to merge 2 commits intomainfrom
copilot/fix-destructure-property-manager-issue

Copilot AI commented May 6, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented May 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Copilot AI commented May 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

github-actions Bot commented May 7, 2026

📊 Size report

dist/dev 0.01%↑

dist/prod 0.01%↑

smoke-tests/v2-app-hello-world-template/dist 0.01%↑

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented May 6, 2026 •

edited

Loading

dist/dev `0.01%↑`

dist/prod `0.01%↑`

smoke-tests/v2-app-hello-world-template/dist `0.01%↑`