OpenCLIP models #35
Merged
OpenCLIP models #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eloy-encord
approved these changes
Feb 28, 2024
eloy-encord
requested changes
Feb 28, 2024
Jim-Encord
force-pushed
the
jb/feat_openclip
branch
from
42ca50e to
1ba62d1
Compare
eloy-encord
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not the ideal method. I spent quite a while battling with the different ways of having multiple collate functions and whatnot. Actually it's possible that at the end of all, I didn't need different collate functions. Just transform functions and embedding functions.
Currently, it's a bit tragic as for OpenCLIP models, we only encode them one at a time. model.encode_image takes a singular image. With some time spent hacking around at the internals, the issue can be resolved.