-
Notifications
You must be signed in to change notification settings - Fork 334
Fix Private_Access_Error in Ordered_Multi_Value_Key
#14543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
rivate_Access_Error in Ordered_Multi_Value_KeyPrivate_Access_Error in Ordered_Multi_Value_Key
JaroslavTulach
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please hide (if it is not possible to remove) test only APIs.
distribution/lib/Standard/Table/0.0.0-dev/src/In_Memory_Column.enso
Outdated
Show resolved
Hide resolved
JaroslavTulach
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding the get_java_column_test_only into In_Memory_Test_Helpers is more veiled than having it directly in the In_Memory_Column. Thank you.
Added a test-only accessor.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.