Skip to content

Conversation

@GregoryTravis
Copy link
Contributor

@GregoryTravis GregoryTravis commented Dec 29, 2025

Added a test-only accessor.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@GregoryTravis GregoryTravis marked this pull request as ready for review December 29, 2025 20:07
@GregoryTravis GregoryTravis added the CI: No changelog needed Do not require a changelog entry for this PR. label Dec 29, 2025
@GregoryTravis GregoryTravis changed the title Fix Private_Access_Error in Ordered_Multi_Value_Key Fix Private_Access_Error in Ordered_Multi_Value_Key Dec 29, 2025
Copy link
Member

@JaroslavTulach JaroslavTulach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please hide (if it is not possible to remove) test only APIs.

Copy link
Member

@JaroslavTulach JaroslavTulach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding the get_java_column_test_only into In_Memory_Test_Helpers is more veiled than having it directly in the In_Memory_Column. Thank you.

@GregoryTravis GregoryTravis added the CI: Ready to merge This PR is eligible for automatic merge label Jan 6, 2026
@github-actions github-actions bot added the -libs-API-change-Table Marks a PR that changes the public API of Standard.Table label Jan 6, 2026
@mergify mergify bot merged commit cfebe3d into develop Jan 7, 2026
85 of 90 checks passed
@mergify mergify bot deleted the wip/gmt/13899-fix-mvk-private-access branch January 7, 2026 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

-libs-API-change-Table Marks a PR that changes the public API of Standard.Table CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants