Skip to content

Fix Private_Access_Error in Ordered_Multi_Value_Key #14543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 7 commits into from
Jan 7, 2026
Merged

Fix Private_Access_Error in Ordered_Multi_Value_Key #14543

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1f4cf93
fix
GregoryTravis Dec 29, 2025
79256cb
Merge branch 'develop' into wip/gmt/13899-fix-mvk-private-access
GregoryTravis Dec 30, 2025
3e59f5b
Merge branch 'develop' into wip/gmt/13899-fix-mvk-private-access
GregoryTravis Jan 2, 2026
bd42c41
move helper to internal module
GregoryTravis Jan 2, 2026
adb3372
Merge branch 'develop' into wip/gmt/13899-fix-mvk-private-access
GregoryTravis Jan 5, 2026
7750780
remove _test_only, restore missing line, unused import
GregoryTravis Jan 5, 2026
93125a4
api
GregoryTravis Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions distribution/lib/Standard/Table/0.0.0-dev/src/Internal/In_Memory_Test_Helpers.enso
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
import project.In_Memory_Column.In_Memory_Column

polyglot java import org.enso.table.data.table.Column as Java_Column

## ---
private: true
---
get_java_column_test_only (column : In_Memory_Column) -> Java_Column =
column.java_column
37 changes: 26 additions & 11 deletions test/Benchmarks/src/Table/Internal/Multi_Value_Key.enso
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
from Standard.Base import all

from Standard.Table import Table, Value_Type
import Standard.Table.In_Memory_Column.In_Memory_Column

Check warning on line 4 in test/Benchmarks/src/Table/Internal/Multi_Value_Key.enso

View workflow job for this annotation

GitHub Actions / ⚙️ Checks / Enso Code Lint (linux, amd64)

Enso Compiler Warning @ /runner/_work/enso/enso/test/test/Benchmarks/src/Table/Internal/Multi_Value_Key.enso 

The import is not used
import Standard.Table.Internal.Multi_Value_Key.Ordered_Multi_Value_Key
import Standard.Table.Internal.Multi_Value_Key.Unordered_Multi_Value_Key
from Standard.Table.Internal.In_Memory_Test_Helpers import get_java_column_test_only

from Standard.Test import Bench

polyglot java import org.enso.table.data.index.OrderedMultiValueKey
Expand Down Expand Up @@ -77,31 +80,43 @@
compare_keys key1 key2 = Comparable.< self=key1 that=key2
compare_ordered_keys make_key table compare_keys

run_java table =
java_columns = table.columns.map column-> get_java_column_test_only column
directions = Vector.fill java_columns.length 1
make_key row_ix = OrderedMultiValueKey.new java_columns row_ix directions
compare_keys key1 key2 = key1.compareTo key2 < 0
compare_ordered_keys make_key table compare_keys

group_builder.specify "Primitive_Enso" <|
run_enso (data.table.select_columns ["X", "Y"])
group_builder.specify "Custom_Object_Enso" <|
run_enso (data.table.select_columns ["X", "Z"])
# FIXME: https://github.com/enso-org/enso/issues/13899
#group_builder.specify "Primitive_Java" <|
# run_java (data.table.select_columns ["X", "Y"])
#group_builder.specify "Custom_Object_Java" <|
# run_java (data.table.select_columns ["X", "Z"])
group_builder.specify "Primitive_Java" <|
run_java (data.table.select_columns ["X", "Y"])
group_builder.specify "Custom_Object_Java" <|
run_java (data.table.select_columns ["X", "Z"])

builder.group ("Unordered_Multi_Value_Key" + num_rows.to_text) options group_builder->
run_enso table =
key_columns = table.columns
make_key row_ix = Unordered_Multi_Value_Key.from_row key_columns row_ix

Check warning on line 102 in test/Benchmarks/src/Table/Internal/Multi_Value_Key.enso

View workflow job for this annotation

GitHub Actions / ⚙️ Checks / Enso Code Lint (linux, amd64)

Enso Compiler Warning @ /runner/_work/enso/enso/test/test/Benchmarks/src/Table/Internal/Multi_Value_Key.enso 

Unused variable make_key.
get_hash key = key.hash_code

Check warning on line 103 in test/Benchmarks/src/Table/Internal/Multi_Value_Key.enso

View workflow job for this annotation

GitHub Actions / ⚙️ Checks / Enso Code Lint (linux, amd64)

Enso Compiler Warning @ /runner/_work/enso/enso/test/test/Benchmarks/src/Table/Internal/Multi_Value_Key.enso 

Unused variable get_hash.

run_java table =
java_columns = table.columns.map column-> get_java_column_test_only column
text_folding_strategies = Vector.fill java_columns.length TextFoldingStrategy.unicodeNormalizedFold
make_key row_ix = UnorderedMultiValueKey.new java_columns row_ix text_folding_strategies
get_hash key = key.hashCode
compute_hashcodes make_key table get_hash

group_builder.specify "Primitive_Enso" <|
run_enso (data.table.select_columns ["X", "Y"])
group_builder.specify "Custom_Object_Enso" <|
run_enso (data.table.select_columns ["X", "Z"])
# FIXME: https://github.com/enso-org/enso/issues/13899
#group_builder.specify "Primitive_Java" <|
# run_java (data.table.select_columns ["X", "Y"])
#group_builder.specify "Custom_Object_Java" <|
# run_java (data.table.select_columns ["X", "Z"])
group_builder.specify "Primitive_Java" <|
run_java (data.table.select_columns ["X", "Y"])
group_builder.specify "Custom_Object_Java" <|
run_java (data.table.select_columns ["X", "Z"])

main = collect_benches . run_main ".*Custom_Object_Java"

main = collect_benches . run_main
Loading