-
Notifications
You must be signed in to change notification settings - Fork 334
Using Standard.AWS in Dual JVM mode
#14568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jdunkerley
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice if really this small.
|
There is a single failure that needs to be fixed: ✅ should be able to copy files Fixed by 1b166ab |
| _ : NotDirectoryException -> Error.throw (File_Error.Not_A_Directory associated_file) | ||
| _ -> Error.throw (File_Error.IO_Error associated_file "An IO error has occurred: "+io_exception.to_text) | ||
|
|
||
| handle_java_exceptions (file : File | Nothing) ~action = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- usual problem with dual JVM exceptions, @jdunkerley
- solves Using
Standard.AWSin Dual JVM mode #14568 (comment) by copying bunch of code from handle_java_exceptions (file : File | Nothing) ~action =
Proper Fix
- proper fix would be to handle these conversions in Java
- and create instance of
File_Errordirectly in Java - as suggested at Run
Standard.Googlein dual JVM mode #14040 (comment)
Pull Request Description
Standard.Snowflakein dual JVM mode #14474Standard.Googlein dual JVM mode #14040Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,