Skip to content

Conversation

@JaroslavTulach
Copy link
Member

@JaroslavTulach JaroslavTulach commented Jan 6, 2026

Pull Request Description

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

@JaroslavTulach JaroslavTulach self-assigned this Jan 6, 2026
@github-actions github-actions bot added the -libs-API-change-Base Marks a PR that changes the public API of Standard.Base label Jan 6, 2026
Copy link
Member

@jdunkerley jdunkerley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice if really this small.

@JaroslavTulach
Copy link
Member Author

JaroslavTulach commented Jan 6, 2026

There is a single failure that needs to be fixed:

✅ should be able to copy files
✅ should be able to move files
❌ should fail if the source file does not exist
An unexpected panic was thrown: java.io.UncheckedIOException: java.nio.file.NoSuchFileException: /tmp/local12334118053566306720src.txt
✅ should fail to copy/move a file if it exists and replace_existing=False
✅ should overwrite existing destination in copy/move if replace_existing=True

Fixed by 1b166ab

_ : NotDirectoryException -> Error.throw (File_Error.Not_A_Directory associated_file)
_ -> Error.throw (File_Error.IO_Error associated_file "An IO error has occurred: "+io_exception.to_text)

handle_java_exceptions (file : File | Nothing) ~action =
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proper Fix

@JaroslavTulach JaroslavTulach mentioned this pull request Jan 7, 2026
4 tasks
@JaroslavTulach JaroslavTulach merged commit ed670eb into develop Jan 7, 2026
87 of 90 checks passed
@JaroslavTulach JaroslavTulach deleted the wip/jtulach/AWSinDualJvmMode branch January 7, 2026 02:33
@enso-bot enso-bot bot mentioned this pull request Jan 7, 2026
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

-libs-API-change-Base Marks a PR that changes the public API of Standard.Base

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants