-
Notifications
You must be signed in to change notification settings - Fork 336
Registering cons the normal way provides proper defaulted arguments support #14611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
JaroslavTulach
merged 22 commits into
develop
from
wip/jtulach/OveruseOfBuiltinTypes13664
Jan 16, 2026
Merged
Registering cons the normal way provides proper defaulted arguments support #14611
JaroslavTulach
merged 22 commits into
develop
from
wip/jtulach/OveruseOfBuiltinTypes13664
Jan 16, 2026
+282
−811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GregoryTravis
approved these changes
Jan 12, 2026
2 tasks
4a8731f to
23af588
Compare
JaroslavTulach
commented
Jan 14, 2026
| for (var t : threads.keySet()) { | ||
| try { | ||
| t.join(); | ||
| // wait for threads, but don't deadlock |
Member
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- This is the deadlock.txt I have seen.
- Happens when
guest-codewants to initialize Java while some other thread is callingContext.close() - I guess we don't need 100% correctness here
- after 10s lets give up
- close the context while a thread is still running
…eOfBuiltinTypes13664
Member
Author
…g/enso into wip/jtulach/OveruseOfBuiltinTypes13664
4e6
approved these changes
Jan 15, 2026
Akirathan
approved these changes
Jan 15, 2026
Member
Akirathan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Decreasing the number of builtins seems like a good path.
|
Jaroslav Tulach reports a new STANDUP for yesterday (2026-01-16): Progress: .
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
-libs-API-change-Base
Marks a PR that changes the public API of Standard.Base
CI: Clean build required
CI runners will be cleaned before and after this PR is built.
CI: No changelog needed
Do not require a changelog entry for this PR.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
@Builtin_TypeannotationsAtominstances as builtin typesVectororDateare really builtin typesprivateconstructors is now enforced as demonstrated by a8f956dimport Standard.BaseImportant Notes
Missing_Argumenta@Builtin_Typeat all?@Builtin_Typeis used just for this purposeRejected
Missing_Argumentonlytp.builtinType()makes the runtime "fubar"Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,