fix: skip cross-repo closes refs in PR linked issues - #1020
Closed
aliangm wants to merge 1 commit into
Closed
Conversation
GitHub computes authorAssociation against the issue's repo, so a
`closes ownerB/repoB#N` link from a cross-repo issue could grant the
1.66x MAINTAINER_ISSUE_MULTIPLIER to a PR in repo A.
Add `repository { nameWithOwner }` to the closingIssuesReferences
GraphQL fragment and drop nodes whose repo doesn't match the PR's repo
at construction time. Cached payloads without `repository` are passed
through unchanged for backwards compat.
Collaborator
|
CI has been failing for 12+ hours with no fix pushed. Closing. |
Contributor
Author
|
@anderdc Would you please reopen it? I will take it as a warning seriously |
This was referenced May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
authorAssociationagainst the issue's repo, so acloses ownerB/repoB#Nlink from a cross-repo issue could grant the 1.66×MAINTAINER_ISSUE_MULTIPLIERto a PR in repo A.repository { nameWithOwner }to theclosingIssuesReferencesGraphQL fragment and drop nodes whose repo doesn't match the PR's repo at construction time.repositoryare passed through unchanged (backwards compat until refetch).Test plan
pytest tests/test_classes.py— new tests for cross-repo skip (case-insensitive) and missing-repo backwards compatpytest tests/) — 764 passedFixes #1019