Skip to content

Commit

Permalink
Fix: set workspace in environment create (#189)
Browse files Browse the repository at this point in the history
* Create Environment resource with custom workspace name
* UT
  • Loading branch information
eyalatzmon committed Dec 20, 2021
1 parent a7ead19 commit d36c056
Show file tree
Hide file tree
Showing 2 changed files with 27 additions and 11 deletions.
9 changes: 7 additions & 2 deletions env0/resource_environment.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,13 @@ import (
"context"
"errors"
"fmt"
"log"
"regexp"

"github.com/env0/terraform-provider-env0/client"
"github.com/google/uuid"
"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
"log"
"regexp"
)

func resourceEnvironment() *schema.Resource {
Expand Down Expand Up @@ -346,6 +347,10 @@ func getCreatePayload(d *schema.ResourceData, apiClient client.ApiClientInterfac
payload.ProjectId = projectId.(string)
}

if workspace, ok := d.GetOk("workspace"); ok {
payload.WorkspaceName = workspace.(string)
}

if d.HasChange("deploy_on_push") {
continuousDeployment := d.Get("deploy_on_push").(bool)
payload.ContinuousDeployment = &continuousDeployment
Expand Down
29 changes: 20 additions & 9 deletions env0/resource_environment_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,13 @@ package env0
import (
"errors"
"fmt"
"github.com/env0/terraform-provider-env0/client"
"github.com/golang/mock/gomock"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
"regexp"
"strings"
"testing"

"github.com/env0/terraform-provider-env0/client"
"github.com/golang/mock/gomock"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
)

func TestUnitEnvironmentResource(t *testing.T) {
Expand All @@ -18,18 +19,20 @@ func TestUnitEnvironmentResource(t *testing.T) {
templateId := "template-id"

environment := client.Environment{
Id: "id0",
Name: "my-environment",
ProjectId: "project-id",
Id: "id0",
Name: "my-environment",
ProjectId: "project-id",
WorkspaceName: "workspace-name",
LatestDeploymentLog: client.DeploymentLog{
BlueprintId: templateId,
},
}

updatedEnvironment := client.Environment{
Id: environment.Id,
Name: "my-updated-environment-name",
ProjectId: "project-id",
Id: environment.Id,
Name: "my-updated-environment-name",
ProjectId: "project-id",
WorkspaceName: environment.WorkspaceName,
LatestDeploymentLog: client.DeploymentLog{
BlueprintId: templateId,
},
Expand All @@ -40,6 +43,7 @@ func TestUnitEnvironmentResource(t *testing.T) {
"name": environment.Name,
"project_id": environment.ProjectId,
"template_id": environment.LatestDeploymentLog.BlueprintId,
"workspace": environment.WorkspaceName,
"force_destroy": true,
})
}
Expand All @@ -55,6 +59,7 @@ func TestUnitEnvironmentResource(t *testing.T) {
resource.TestCheckResourceAttr(accessor, "name", environment.Name),
resource.TestCheckResourceAttr(accessor, "project_id", environment.ProjectId),
resource.TestCheckResourceAttr(accessor, "template_id", templateId),
resource.TestCheckResourceAttr(accessor, "workspace", environment.WorkspaceName),
),
},
{
Expand All @@ -64,6 +69,7 @@ func TestUnitEnvironmentResource(t *testing.T) {
resource.TestCheckResourceAttr(accessor, "name", updatedEnvironment.Name),
resource.TestCheckResourceAttr(accessor, "project_id", updatedEnvironment.ProjectId),
resource.TestCheckResourceAttr(accessor, "template_id", templateId),
resource.TestCheckResourceAttr(accessor, "workspace", environment.WorkspaceName),
),
},
},
Expand All @@ -73,6 +79,7 @@ func TestUnitEnvironmentResource(t *testing.T) {
mock.EXPECT().EnvironmentCreate(client.EnvironmentCreate{
Name: environment.Name,
ProjectId: environment.ProjectId,
WorkspaceName: environment.WorkspaceName,
AutoDeployOnPathChangesOnly: &autoDeployOnPathChangesOnlyDefault,
AutoDeployByCustomGlob: autoDeployByCustomGlobDefault,
DeployRequest: &client.DeployRequest{
Expand Down Expand Up @@ -219,6 +226,7 @@ func TestUnitEnvironmentResource(t *testing.T) {
mock.EXPECT().EnvironmentCreate(client.EnvironmentCreate{
Name: environment.Name,
ProjectId: environment.ProjectId,
WorkspaceName: environment.WorkspaceName,
AutoDeployOnPathChangesOnly: &autoDeployOnPathChangesOnlyDefault,
AutoDeployByCustomGlob: autoDeployByCustomGlobDefault,
DeployRequest: &client.DeployRequest{
Expand Down Expand Up @@ -680,6 +688,7 @@ func TestUnitEnvironmentResource(t *testing.T) {
mock.EXPECT().EnvironmentCreate(client.EnvironmentCreate{
Name: environment.Name,
ProjectId: environment.ProjectId,
WorkspaceName: environment.WorkspaceName,
AutoDeployOnPathChangesOnly: &autoDeployOnPathChangesOnlyDefault,
AutoDeployByCustomGlob: autoDeployByCustomGlobDefault,
DeployRequest: &client.DeployRequest{
Expand Down Expand Up @@ -707,6 +716,7 @@ func TestUnitEnvironmentResource(t *testing.T) {
mock.EXPECT().EnvironmentCreate(client.EnvironmentCreate{
Name: environment.Name,
ProjectId: environment.ProjectId,
WorkspaceName: environment.WorkspaceName,
AutoDeployOnPathChangesOnly: &autoDeployOnPathChangesOnlyDefault,
AutoDeployByCustomGlob: autoDeployByCustomGlobDefault,
DeployRequest: &client.DeployRequest{
Expand Down Expand Up @@ -781,6 +791,7 @@ func TestUnitEnvironmentResource(t *testing.T) {
mock.EXPECT().EnvironmentCreate(client.EnvironmentCreate{
Name: environment.Name,
ProjectId: environment.ProjectId,
WorkspaceName: environment.WorkspaceName,
AutoDeployOnPathChangesOnly: &autoDeployOnPathChangesOnlyDefault,
AutoDeployByCustomGlob: autoDeployByCustomGlobDefault,
DeployRequest: &client.DeployRequest{
Expand Down

0 comments on commit d36c056

Please sign in to comment.