-
Notifications
You must be signed in to change notification settings - Fork 24
Fix hashing logic for config strings #608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThe implementation of the Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
🔇 Additional comments (2)
|
This is my first time using codex, It isn't actually fixing a bug really since the hex can just be a string but I agree it should be should be a proper hex string
Summary
HashString::from_string
uses hex formatting like other hashing helpersTesting
cargo test -p cli --quiet
(fails: failed to fetch crates)https://chatgpt.com/codex/tasks/task_e_68530385f0e88327bb4e08463ecfe0cb
Summary by CodeRabbit
Bug Fixes
Tests