Skip to content

Fix hashing logic for config strings #608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix hashing logic for config strings #608

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions codegenerator/cli/src/persisted_state/hash_string.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,9 @@ impl HashString {
pub fn from_string(string: String) -> Self {
let mut hasher = Sha256::new();
hasher.update(string);
let hash = hasher.finalize().to_vec();
HashString(format!("{:?}", hash))
let hash = hasher.finalize();
// Use hexadecimal encoding to match other hash functions
HashString(format!("{:x}", hash))
}

#[cfg(test)]
Expand Down Expand Up @@ -107,6 +108,15 @@ mod test {
);
}

#[test]
fn string_hash() {
let hash = HashString::from_string("config".to_string());
assert_eq!(
hash.inner(),
"b79606fb3afea5bd1609ed40b622142f1c98125abcfe89a76a661b0e8e343910".to_string()
);
}

#[test]
#[should_panic]
fn fail_hash_empty_fail() {
Expand Down