feat(no-sync): Add ignores option
#364
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scagood
changed the title
ignores option
This was
linked to
issues
Oct 18, 2024
scagood
changed the title
ignores optionignores option
|
sorry for the lateness, will review it asap! :) |
the rule was ported from eslint core (deprecated since eslint v7). This is how it was first developed, and I didn't find a relevant discussion: eslint/eslint@37cf3d8 I'm fine to just checking node.js apis, or at the very least, it can just ignore user-defined functions: var fooSync = function () {}; // do not reprot! |
aladdin-add
reviewed
Nov 15, 2024
aladdin-add
force-pushed
the
no-sync-issues
branch
from
bb55a55
to
fd84a33
Compare
|
Superceeded by #386 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am still on the fence about #354
As one part of me thinks that we should be specific to the node apis only.
The other part of me thinks that we should make all possibly sync function calls as bad in the node environment 🤔
I am slowly leaning towards using the
ReferenceTrackerfrom eslint-utils to only mark call expressions from node apis.