Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(no-sync): Add ignores option #386

Merged
merged 3 commits into from
Nov 18, 2024
Merged

feat(no-sync): Add ignores option #386

merged 3 commits into from
Nov 18, 2024

Conversation

aladdin-add
Copy link

a successor of #364.

@aladdin-add aladdin-add mentioned this pull request Nov 18, 2024
Closed
This was linked to issues Nov 18, 2024
Bug: n/no-sync incorrectly applies to method definitions #355
Closed
Bug: no-sync fail positive #354
Closed
scagood
scagood approved these changes Nov 18, 2024
View reviewed changes
Copy link

@scagood scagood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@scagood scagood marked this pull request as ready for review November 18, 2024 10:53
@aladdin-add aladdin-add merged commit c8fbf00 into master Nov 18, 2024
31 checks passed
@aladdin-add aladdin-add deleted the pr-364 branch November 18, 2024 12:20
@github-actions github-actions bot mentioned this pull request Nov 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scagood scagood scagood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: n/no-sync incorrectly applies to method definitions Bug: no-sync fail positive
2 participants
@aladdin-add @scagood