-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow pre-releases of ESLint 9 #206
Conversation
Fixes #197 using the solution from eslint-community/eslint-utils#206
Fixes #197 using the solution from eslint-community/eslint-utils#206
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to make a pull request to the beta
branch to release it as a beta version.
However, before that, we may need to recreate the beta
branch.
@ota-meshi I think this can be merged and released in stable, shouldn't be an issue for |
Hmmm. I am not sure about that. I would think that anything that works with a non-stable version is not a stable version. |
Depends on what the intention of
Or if it is to say:
Sadly npm have no way to express the latter (see npm/rfcs#397), hence why this workaround is needed if the latter is what we want to convey, and that's what I think we should convey. We should never claim to be incompatible with a future release unless we know to be incompatible, as that causes the issues that eg @fisker sees in #183 |
Hmm. However, I'm still not sure. eslint-plugin-unicorn (pull request) also does not include 9.0.0-0 in |
Do you have a better solution before something like npm/rfcs#397 arrives and allows for peer dependency ranges to match all future version rather than just stable future versions? Would of course be great to get @fisker's point of view on this solution as well, but since |
I did request guidance from ESLint itself here: eslint/eslint#18093 (comment) Maybe I should promote that into an issue on its own |
I don't think they are the same, I'm pretty sure if we release/install |
A reminder: |
@fisker Are you in favor of releasing eslint-utils as a beta version? I think we have a workflow that allows us to pre-release using the eslint-utils/.github/workflows/ci.yml Line 124 in 6a7a3f3
|
Just need a version, not really care the number. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since eslint-utils is a dependency of many plugins it makes sense that it does the first move in enabling ESLint 9 pre-releases
I agree with you on that. I think it would be better to pre-release eslint-utils if possible, but I'm not strongly stick to it.
From #183 (comment)
|
Fixes #183, but with the caveats mentioned in npm/rfcs#397 (comment) :
I think the automatic installation of a pre-release is less of an issue for this module than for eg eslint-community/eslint-plugin-n#197 as
@eslint-community/eslint-utils
is never installed by an end-user directly, only indirectly through other plugins.For eg
eslint-plugin-n
it may be a deal breaker