-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
required Ruby 2.7, add new CI workflow with graphql-ruby master branch #14
base: master
Are you sure you want to change the base?
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,69 @@ | ||
name: Edge Build | ||
|
||
on: | ||
push: | ||
branches: [ master ] | ||
pull_request: | ||
schedule: | ||
- cron: "10 4 * * */2" | ||
|
||
jobs: | ||
edge-test: | ||
runs-on: ubuntu-latest | ||
env: | ||
BUNDLE_JOBS: 4 | ||
BUNDLE_RETRY: 3 | ||
BUNDLE_GEMFILE: gemfiles/graphql_master.gemfile | ||
DATABASE_URL: postgres://postgres:postgres@localhost:5432 | ||
ELASTICSEARCH_URL: http://localhost:9200 | ||
Comment on lines
+17
to
+18
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why do we need these two? The setup must be similar to And I'm not sure we need to extract this into a separate workflow; it can be another parameter in the Also, There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Because in the matrix we put "head" ruby (for master ruby), and this ruby version puts About naming - OK, agree |
||
CI: true | ||
strategy: | ||
fail-fast: false | ||
matrix: | ||
ruby: [ '2.7', '3.0', '3.1', '3.2', head ] | ||
services: | ||
postgres: | ||
image: postgres:13 | ||
ports: ["5432:5432"] | ||
env: | ||
POSTGRES_PASSWORD: postgres | ||
options: >- | ||
--health-cmd pg_isready | ||
--health-interval 10s | ||
--health-timeout 5s | ||
--health-retries 5 | ||
|
||
elasticsearch: | ||
image: elasticsearch:7.12.1 | ||
ports: | ||
- 9200:9200 | ||
env: | ||
ES_JAVA_OPTS: -Xms64m -Xmx256m | ||
discovery.type: single-node | ||
http.cors.enabled: "true" | ||
bootstrap.memory_lock: "true" | ||
options: >- | ||
--health-cmd "curl http://localhost:9200/_cluster/health" | ||
--health-interval 10s | ||
--health-timeout 5s | ||
--health-retries 10 | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- name: Install system deps | ||
run: | | ||
sudo apt-get update | ||
sudo apt-get -yqq install libpq-dev | ||
- uses: ruby/setup-ruby@v1 | ||
with: | ||
ruby-version: ${{ matrix.ruby }} | ||
bundler-cache: true | ||
- name: Create DB | ||
run: | | ||
env PGPASSWORD=postgres createdb -h localhost -U postgres graphql_paging | ||
- name: Run Standard commands | ||
run: | | ||
bundle exec standardrb | ||
- name: Run RSpec | ||
run: | | ||
bundle exec rspec -f d --force-color | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,7 +3,7 @@ | |
/_yardoc/ | ||
/coverage/ | ||
/doc/ | ||
/gemfiles/ | ||
/gemfiles/*.lock | ||
/pkg/ | ||
/spec/reports/ | ||
/tmp/ | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
ruby_version: 2.6 | ||
ruby_version: 2.7 |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
source "https://rubygems.org" | ||
|
||
gem "graphql", github: "rmosolgo/graphql-ruby" | ||
|
||
gemspec path: ".." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2.7 is dead for 7 months already, maybe we can drop it too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm, okay, thanks :)
done