Rename system.* to system_* in a some files #2330
Conversation
Ike Plugins (test-keeper)Thank you @jarifibrahim for this contribution!
It seems that this PR already contains some added or changed tests. Good job! For more information please head over to official documentation. You can find there how to configure the plugin. |
jarifibrahim
changed the title
| RemoteAssigneeLogins = "system.assignees.login" | ||
| RemoteAssigneeProfileURLs = "system.assignees.profile_url" | ||
| remoteCreatorLogin = "system_creator_login" | ||
| remoteCreatorProfileURL = "system_creator_profile_url" |
There was a problem hiding this comment.
As discussed on a call last Friday, please beware that we cannot simply replace system. with system_ but that we also might have to deal with multiple JSONAPI violations per field name.
|
|
||
| if strings.Contains(fieldName, ".") { | ||
| // Check if the field name contains an underscore | ||
| if strings.Contains(fieldName, "_") { |
There was a problem hiding this comment.
This reminds me that this piece of code needs some special treatment as the logic was previously to only handle system.XXX fields here and to distinguish between those fields that map to columns inside the work_items table and those that actually go to the fields column.
There was a problem hiding this comment.
@kwk I guess you're talking about this piece of code
fabric8-wit/workitem/expression_compiler.go
Lines 108 to 117 in bbd8f88
Do you think I should fix something? (I couldn't understand what did you want me to change)
There was a problem hiding this comment.
No No, this was just a mental note to myself.
* Rename system.* to system_* in a all files (#2330) * Update branch osio-story-743-rename-fields (#2350) * Add temporary code for field rename (#2333) * Add replaceFieldName and addFieldName with tests * Remove unnecessary log.Error from golden_files_test.go * Fix failing test in expression_compiler_blackbox_test.go * Skip FullTextSearch and iteration test until migrations are added * Add golden files with old and new field names * Add todo to skipped tests * Add foo.bar test for expression_compiler * Update /workitemtype response for field rename (#2335) * Change workitemtype response payload * Update golden files related to workitemtype response change * Add onField to the /workitem/event response (#2337) * Add event_name attribute to the event response * fix golden files related to workitem_event * Rename event_name to onField in event/show response * Update golden files * Add migrations for field name rename (#2340) * Add migration for workitem_type field renames * Add field rename migrations for work_items and work_item_revisions table * Enable skipped test for field rename and update TSV trigger (#2342) * Add migration for TSV vector and triggers for field renames * Change migration file names
This is the first PR in a series of PR to rename all system.* fields to system_* fields.
I've broken the changes into separate PRs so that it can be easily reviewed.
This PR will be merged to osio-story-743-rename-fields branch. The tests would fail because this is not the complete implementation. Once all changes have been merged to osio-story-743-rename-fields branch, I'll create a new PR to merge this branch into master. I hope this will make it easier to review the code.
See #2177 and #2177 (comment)
This PR does not change any golden files. They will be updated in #2333 PR.