Skip to content
This repository has been archived by the owner on Mar 11, 2021. It is now read-only.

Conversation

jarifibrahim
Copy link
Member

@jarifibrahim jarifibrahim commented Oct 25, 2018

This PR builds upon #2330. I will update this PR once #2330 is merged.

This PR updates all the golden files.

The full text search depends on the TSV which are not yet fixed and the IfModifiedSince tests depend on the triggers defined on work_item table. We have not yet fixed a database and it's causing test failures. These tests have been temporarily skipped by b5b0251. I have created an issue for this #2332.

@jarifibrahim jarifibrahim force-pushed the osio-story-743-part-0-golden-files branch from b5b0251 to 740b5da Compare October 26, 2018 08:31
@codecov
Copy link

codecov bot commented Oct 26, 2018

Codecov Report

Merging #2331 into osio-story-743-rename-fields will decrease coverage by 0.1%.
The diff coverage is 91.66%.

Impacted file tree graph

@@                       Coverage Diff                        @@
##           osio-story-743-rename-fields    #2331      +/-   ##
================================================================
- Coverage                         70.18%   70.08%   -0.11%     
================================================================
  Files                               171      171              
  Lines                             16625    16625              
================================================================
- Hits                              11669    11652      -17     
- Misses                             3828     3841      +13     
- Partials                           1128     1132       +4
Impacted Files Coverage Δ
workitem/workitem.go 57.64% <ø> (ø) ⬆️
workitem/workitemtype.go 73.62% <ø> (ø) ⬆️
remoteworkitem/remoteworkitem.go 78.87% <ø> (ø) ⬆️
workitem/table_join.go 89.89% <ø> (ø) ⬆️
controller/planner_backlog.go 64.13% <0%> (ø) ⬆️
workitem/workitem_repository.go 67.79% <100%> (-0.23%) ⬇️
codebase/codebase.go 73% <100%> (ø) ⬆️
workitem/expression_compiler.go 81.17% <100%> (ø) ⬆️
controller/workitem.go 81.18% <100%> (-0.56%) ⬇️
controller/workitems.go 77.43% <100%> (ø) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44739f8...740b5da. Read the comment docs.

@jarifibrahim
Copy link
Member Author

Closing this in favour of #2333. #2333 contains all the golden files with final updates.

This PR had golden files changed from system.title to system_title. #2333 has golden files changed from system.title to system.title and system_title that is, both the field names are present. Since we need the later, I'm closing this PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant