RNGP - Move matchingFallbacks to be called inside maybeCreate("debugOptimized")
#54186
+2
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Optimized")` Summary: The `marchingFallback` directive is applied directly on the build type. However here is invoked inside the `externalNativeBuild` making it confusing, because in reality it has nothing to do with `externalNativeBuild`. So I'm moving it to the correct location (this has no effect on the build setup, is just to make the code easier to read). Changelog: [Internal] [Changed] - Differential Revision: D84921628
meta-cla
bot
added
the
CLA Signed
|
@cortinico has exported this pull request. If you are a Meta employee, you can view the originating Diff in D84921628. |
|
This pull request has been merged in 50b1bec. |
|
This pull request was successfully merged by @cortinico in 50b1bec When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The
marchingFallbackdirective is applied directly on the build type.However here is invoked inside the
externalNativeBuildmaking it confusing, because in realityit has nothing to do with
externalNativeBuild. So I'm moving it to the correct location(this has no effect on the build setup, is just to make the code easier to read).
Changelog:
[Internal] [Changed] -
Differential Revision: D84921628