[compiler] Refactor traverseFunction in Entrypoint #30084
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we would traverse and compile a function and add the compiled function to an array of compiled functions captured by context. With this PR, rather than modifying the captured array, the compiled result is returned. A small helper function is used to wrap this call and update the array instead. This change will let us reuse this traversal and compilation pipeline for newly created functions (like when we outline jsx). [ghstack-poisoned]
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
This was referenced Jun 25, 2024
|
Comparing: f5d2feb...79a5f1e Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
Previously, we would traverse and compile a function and add the compiled function to an array of compiled functions captured by context. With this PR, rather than modifying the captured array, the compiled result is returned. A small helper function is used to wrap this call and update the array instead. This change will let us reuse this traversal and compilation pipeline for newly created functions (like when we outline jsx). [ghstack-poisoned]
kassens
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Previously, we would traverse and compile a function and add the
compiled function to an array of compiled functions captured by context.
With this PR, rather than modifying the captured array, the compiled
result is returned. A small helper function is used to wrap this call
and update the array instead.
This change will let us reuse this traversal and compilation pipeline
for newly created functions (like when we outline jsx).