[compiled] Refactor codegen for ReactiveFunction #30087
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the codegen for ReactiveFunction into a helper function. This will be reused in the future, when we want to codegen outlined function expressions. There's no functional change with this PR. [ghstack-poisoned]
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was referenced Jun 25, 2024
facebook-github-bot
added
CLA Signed
React Core Team
|
Comparing: f5d2feb...2f54bc3 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
Move the codegen for ReactiveFunction into a helper function. This will be reused in the future, when we want to codegen outlined function expressions. There's no functional change with this PR. [ghstack-poisoned]
josephsavona
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Move the codegen for ReactiveFunction into a helper function.
This will be reused in the future, when we want to codegen outlined
function expressions.
There's no functional change with this PR.