[compiler] Outline JSX with non-jsx children #31400
Closed
+137
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we bailed out on outlining jsx that had children that were not part of the outlined jsx. Now, we add support for children by treating as attributes. [ghstack-poisoned]
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gsathya
added a commit
that referenced
this pull request
Nov 1, 2024
Previously, we bailed out on outlining jsx that had children that were not part of the outlined jsx. Now, we add support for children by treating as attributes. ghstack-source-id: 028ae9ffc65c8b956e1bb0548feb571667def8b2 Pull Request resolved: #31400
facebook-github-bot
added
the
React Core Team
josephsavona
approved these changes
Nov 1, 2024
Comment on lines
219
to
220
| let id = 1; | ||
| function generateName(seen: Set<string>, oldName: string): string { |
There was a problem hiding this comment.
this will cause non-deterministic output, it has to be scoped to the outer transform
Previously, we bailed out on outlining jsx that had children that were not part of the outlined jsx. Now, we add support for children by treating as attributes. [ghstack-poisoned]
gsathya
added a commit
that referenced
this pull request
Nov 6, 2024
Previously, we bailed out on outlining jsx that had children that were not part of the outlined jsx. Now, we add support for children by treating as attributes. ghstack-source-id: 24d32f60148cc189effc23523631c652035a8976 Pull Request resolved: #31400
Previously, we bailed out on outlining jsx that had children that were not part of the outlined jsx. Now, we add support for children by treating as attributes. [ghstack-poisoned]
gsathya
added a commit
that referenced
this pull request
Nov 6, 2024
Previously, we bailed out on outlining jsx that had children that were not part of the outlined jsx. Now, we add support for children by treating as attributes. ghstack-source-id: f8d88aa867847db17ab2b07c574fa5216069a666 Pull Request resolved: #31400
gsathya
added a commit
to gsathya/react
that referenced
this pull request
Nov 6, 2024
Previously, we bailed out on outlining jsx that had children that were not part of the outlined jsx. Now, we add support for children by treating as attributes. ghstack-source-id: f8d88aa867847db17ab2b07c574fa5216069a666 Pull Request resolved: facebook#31400
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Previously, we bailed out on outlining jsx that had children that were
not part of the outlined jsx.
Now, we add support for children by treating as attributes.