Add Gesture Track in Performance Tab #34546
Open
+335
−26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #34543.
For the
startGestureTransition
API, we previously illustrated this in the "Blocking" track because the render itself is blocking. However, it's possible to have updates coming into the blocking track while a gesture is animating (e.g. the setInterval in the fixture). It's therefore useful to be able to visualize the Gesture on its own track so that we can show sync updates at the same time as the animation.We could potentially merge this with the Transition track but I find that a bit misleading. Especially since a Gesture would often then be followed by a Transition right after. So I added a separate track for it. It is its own lane after all. Although it's possible that maybe this track becomes the same as the Optimistic track if that's ever extracted out of sync.