[compiler] _exp version of ValidateNoDerivedComputationsInEffects take precedence over stable version when enabled #35099
+25
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorge-cab
changed the title
josephsavona
approved these changes
Nov 11, 2025
| if ( | ||
| env.config.validateNoDerivedComputationsInEffects && | ||
| !env.config.validateNoDerivedComputationsInEffects_exp | ||
| ) { |
Member
There was a problem hiding this comment.
maybe merge w the _exp case below? if (config.validate...exp) { ...} else if (config.validate...) { ... }
jorge-cab
force-pushed
the
pr35099
branch
3 times, most recently
from
a012a93 to
809eca2
Compare
jorge-cab
force-pushed
the
pr35099
branch
2 times, most recently
from
edaf4e3 to
7b33e13
Compare
Summary: I missed this test case failing and now having @loggerTestOnly after landing some other PRs good to know they're not land blocking
…e precedence over stable version when enabled Summary: We should only run one version of the validation. I think it makes sense that if the exp version is enable it takes precedence over the stable one
jorge-cab
added a commit
that referenced
this pull request
Nov 11, 2025
Summary: I missed this test case failing and now having @loggerTestOnly after landing some other PRs good to know they're not land blocking --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/35100). * #35099 * __->__ #35100
github-actions bot
pushed a commit
that referenced
this pull request
Nov 11, 2025
…e precedence over stable version when enabled (#35099) Summary: We should only run one version of the validation. I think it makes sense that if the exp version is enable it takes precedence over the stable one --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/35099). * __->__ #35099 * #35100 DiffTrain build for [5e94655](5e94655)
github-actions bot
pushed a commit
that referenced
this pull request
Nov 11, 2025
…e precedence over stable version when enabled (#35099) Summary: We should only run one version of the validation. I think it makes sense that if the exp version is enable it takes precedence over the stable one --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/35099). * __->__ #35099 * #35100 DiffTrain build for [5e94655](5e94655)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We should only run one version of the validation. I think it makes sense that if the exp version is enable it takes precedence over the stable one
Stack created with Sapling. Best reviewed with ReviewStack.