-
-
Notifications
You must be signed in to change notification settings - Fork 616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade antlr
to 4.11
#2733
Upgrade antlr
to 4.11
#2733
Conversation
Hi @jlopezpena! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
@Jasha10 I updated the PR to use the dev version of There are many test failures in CI, but they fail in every single PR so I don't think they are related to my changes |
Yup. The core tests are still passing on this PR branch, which is a good sign. |
Still some CI errors happening. They seem to be on the tests for legacy hydra 1.1, if the corresponding behaviour has been deprecated for long they could just be deleted for the next release of hydra, if not they will need to be fixed accordingly |
I don't think the behavior is deprecated. Some legacy Hydra behavior is still supported via the version_base setting. I'll take a look at those failures -- they certainly do seem unrelated to this pr. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to move forward with merging this PR and the sister PR omry/omegaconf#1114. The CI failures here are unrelated to the changes from this PR.
Once you know what the released version of |
This is looking good except for the python3.7 tests. It looks like omegaconf==2.4.0.dev2 cannot be installed with python3.7. I'm not sure what's causing this, but anyway our options are:
I am biased towards the former option. |
I don't have strong feelings either way, but python 3.7 hit EOL in June las year, so IMO it shouldn't warrant going through hoops just to make things work on it. It might be the case that after reaching EOL the build wheel was disabled in PyPI and that's why it cannot be installed -- a "build from source" is likely to fail in CI as it needs Java in order to run |
I've submitted PR #2854 to drop support for python3.7. |
Hi @jlopezpena, it seems is an unresolved issue in the windows CI job. Do you have any insight about what's going on here?
|
It says
which suggests we either need to find a way to upgrade the java version on the Windows machine, or rebuild the |
Got it. I'll modify the CI config file to update the Java version. |
Thanks again @jlopezpena. |
I'll be happy to do a release but ideally would want to get the CI working first. See #2909 for current failures related on the Mac CI. If anyone can help debug this, that would be great. |
Motivation
PR following up on this discussion regarding updating
antlr4
binary and runtime to a more recent version.Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Usual tests should suffice, if there is anything broken with the new
antlr
it should fail at processing the grammars at build timeRelated Issues and PRs
In order to merge this PR a new version of
omegaconf
that includes the corresponding update there should be released