130 Refactor controllers into a new file, update skill manager and hardware CI tests #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
facebook-github-bot
added
the
CLA Signed
KavitShah1998
force-pushed
the
130-refactor-skillmanager
branch
5 times, most recently
from
c90e152 to
7b6f5f7
Compare
KavitShah1998
requested review from
jimmytyyang,
rutadesai,
zephirefaith and
akshararai
and removed request for
zephirefaith
KavitShah1998
changed the title
akshararai
reviewed
Feb 8, 2024
There was a problem hiding this comment.
looks great, minor comments but if the tests work then lets merge it?
@jimmytyyang does this look good to you as well?
KavitShah1998
force-pushed
the
130-refactor-skillmanager
branch
from
491b366 to
42d4974
Compare
|
Merging the PR into main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.