Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frank/fix metadata #142

Merged
merged 3 commits into from
Mar 7, 2024
Merged

Frank/fix metadata #142

merged 3 commits into from
Mar 7, 2024

Conversation

frankosterfeld
Copy link

@frankosterfeld frankosterfeld commented Feb 26, 2024 •
edited
Loading

Fixes metadata propagation from Picoscope.

Also update graph-prototype to latest main.

@frankosterfeld
Make per-channel metadata tags compatible with automatic handling
5a3ead9 
The auto-forwarding of sample_rate, signal_name etc. relies on the
short keys (property name without "gr::" prefix, so adapt our manual
per-channel metadata handling to be compatible.
@frankosterfeld frankosterfeld changed the base branch from main to dev-prototype February 26, 2024 13:16
@frankosterfeld frankosterfeld mentioned this pull request Feb 29, 2024
Closed
3 tasks
@frankosterfeld frankosterfeld marked this pull request as ready for review March 7, 2024 16:14
@frankosterfeld frankosterfeld marked this pull request as draft March 7, 2024 21:09
@frankosterfeld
Copy link
Author

now fair-acc/gnuradio4#296 should be merged first (doesn't affect gr-digitizers, but opendigitizer)

@frankosterfeld frankosterfeld marked this pull request as ready for review March 7, 2024 21:13
@RalphSteinhagen RalphSteinhagen merged commit e8c3a49 into dev-prototype Mar 7, 2024
6 checks passed
@RalphSteinhagen RalphSteinhagen deleted the frank/fix-metadata branch March 7, 2024 21:15
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RalphSteinhagen RalphSteinhagen RalphSteinhagen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@frankosterfeld @RalphSteinhagen