-
Notifications
You must be signed in to change notification settings - Fork 958
feat(engine): emit warning when a condition uses deprecated "evt.dir" #3690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(engine): emit warning when a condition uses deprecated "evt.dir" #3690
Conversation
|
This PR may bring feature or behavior changes in the Falco engine and may require the engine version to be bumped. Please double check userspace/engine/falco_engine_version.h file. See versioning for FALCO_ENGINE_VERSION. /hold |
|
/milestone 0.42.0 |
Emit a warning when a rule with a condition using "evt.dir" field is encountered. The direction have been deprecated in the scope of enter event suppression initiative. Signed-off-by: Iacopo Rozzo <[email protected]>
06f5d98 to
f1542d3
Compare
mstemm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest making the error a bit more generic, but I can live with it as written.
|
LGTM label has been added. Git tree hash: 7ef95de6bea5d29dc3d232471325e195ad89b27d
|
Signed-off-by: Iacopo Rozzo <[email protected]>
98a77f9 to
4f1ff8a
Compare
|
LGTM label has been added. Git tree hash: a408e32011e828ef6e5a8b29b9bcaed7ae1f0577
|
false positive |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: irozzo-1A, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area engine
What this PR does / why we need it:
Emit a warning when a rule with a condition using "evt.dir" field is encountered.
The direction have been deprecated in the scope of enter event suppression initiative.
ref: falcosecurity/libs#2588
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Example output:
Does this PR introduce a user-facing change?: