Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Solved input error for the replicator's hub SSL option #1509

Closed
wants to merge 1 commit into from
Closed

Conversation

dylsteck
Copy link

@dylsteck dylsteck commented Oct 12, 2023

Motivation

Input error for the replicators hub SSL option

When answering the prompts during the replicator's installation, the Does your hub use SSL prompt kept returning !!! Invalid !!! despite entering true or false, as prompted to.

Change Summary

The fix checks for true or false in the same statement as opposed to in two separate statements.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review

Additional Context

If this is a relatively large or complex change, provide more details here that will help reviewers


PR-Codex overview

Detailed summary

  • The code in replicator.sh has been modified to handle the input value of HUB_SSL correctly.
  • The variable answer has been renamed to lower_answer for clarity.
  • The conditions for setting the value of HUB_SSL in the .env file have been updated to handle valid input values of "true" or "false".
  • An "Invalid" message is printed if the input value is neither "true" nor "false".

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Oct 12, 2023

⚠️ No Changeset found

Latest commit: 395bbf2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2023 1:06am

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

All modified lines are covered by tests ✅

see 2 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@sds
Copy link
Member

sds commented Oct 12, 2023

Thanks for this! I addressed in #1512 since we wanted to preserve the functionality that recognized entering "yes", "y", "t", or "true" etc. for different answers, but converted them into the canonical "true" string expected by the environment variable.

@sds sds closed this Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants