Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct prompt for HUB_SSL in replicator.sh #1512

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Conversation

sds
Copy link
Member

@sds sds commented Oct 12, 2023

Motivation

We were infinite looping because we weren't looking at the correct value.

Original report in #1509.

Change Summary

Describe the changes being made in 1-2 concise sentences.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review

Additional Context

If this is a relatively large or complex change, provide more details here that will help reviewers


PR-Codex overview

This PR focuses on improving the SSL configuration in the replicator.sh script.

Detailed summary

  • Changed variable name from answer to lower_response for clarity.
  • Updated the condition to check for SSL configuration options (true, t, y, yes) and (false, f, n, no).
  • Added appropriate comments to explain the purpose of the condition.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

We were infinite looping because we weren't looking at the correct
value.
@vercel
Copy link

vercel bot commented Oct 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2023 5:13pm

@changeset-bot
Copy link

changeset-bot bot commented Oct 12, 2023

⚠️ No Changeset found

Latest commit: 845ce3f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sds sds changed the title Fix prompt for HUB_SSL in replicator.sh fix: Correct prompt for HUB_SSL in replicator.sh Oct 12, 2023
@sds sds added the t-bug A fix for a bug with the current system label Oct 12, 2023
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

All modified lines are covered by tests ✅

see 4 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@sds sds merged commit 2781c2c into main Oct 12, 2023
@sds sds deleted the sds/fix-replicator-prompt branch October 12, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-bug A fix for a bug with the current system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant