Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Typos in Documentation and Tests #2460

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

teenager-ETH
Copy link

@teenager-ETH teenager-ETH commented Dec 29, 2024

Fix Typos in Documentation and Tests

Summary

This pull request addresses minor typos in the following files:

  1. apps/hubble/src/test/e2e/gossipNetworkBundle.test.ts
  2. packages/hub-nodejs/docs/signers/EthersV5Eip712Signer.md

Changes Made

1. gossipNetworkBundle.test.ts

  • Fixed a typo in the comment:
    • From: "beacuse"
    • To: "because"

2. EthersV5Eip712Signer.md

  • Fixed a typo in the comment:
    • From: "can't erro"
    • To: "can't error"

Testing

These changes only affect comments and do not impact the functionality of the code. No new tests were added as the code logic remains unchanged.

Checklist


Thank you for reviewing this PR! Let me know if there’s anything else to address.


PR-Codex overview

This PR focuses on correcting minor typographical errors in comments within the documentation and test files related to the EthersV5Eip712Signer and gossipNetworkBundle.

Detailed summary

  • Fixed a typo in the comment for blockHashBytes in packages/hub-nodejs/docs/signers/EthersV5Eip712Signer.md.
  • Corrected a typo in the comment regarding invalid bundle gossiping in apps/hubble/src/test/e2e/gossipNetworkBundle.test.ts.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Dec 29, 2024

⚠️ No Changeset found

Latest commit: 7ab1296

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 29, 2024 11:26pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant