Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Typos in Documentation and Tests #2460

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix Typos in Documentation and Tests #2460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3234908
typo fix EthersV5Eip712Signer.md
teenager-ETH Dec 29, 2024
7ab1296
typo fix gossipNetworkBundle.test.ts
teenager-ETH Dec 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/hubble/src/test/e2e/gossipNetworkBundle.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ describe("gossip network with bundle tests", () => {
expect(duplicatePublishResult.isErr()).toBeTruthy();
expect(duplicatePublishResult._unsafeUnwrapErr().errCode).toBe("bad_request.duplicate");

// Gossiping a invalid bundle will succeed, beacuse the broadcast will succeed but each individual node
// Gossiping a invalid bundle will succeed, because the broadcast will succeed but each individual node
// will report it as invalid, and it will not spread through the network
const invalidPublishResult = await randomNode.gossipBundle(invalidBundle);
expect(invalidPublishResult.isOk()).toBeTruthy();
Expand Down
2 changes: 1 addition & 1 deletion packages/hub-nodejs/docs/signers/EthersV5Eip712Signer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ Generates a 256-bit signature for a VerificationClaim and returns the bytes.
import { FarcasterNetwork, hexStringToBytes, makeVerificationEthAddressClaim } from '@farcaster/hub-nodejs';

const blockHashHex = '0x1d3b0456c920eb503450c7efdcf9b5cf1f5184bf04e5d8ecbcead188a0d02018';
const blockHashBytes = hexStringToBytes(blockHashHex)._unsafeUnwrap(); // Safety: blockHashHex is known and can't erro
const blockHashBytes = hexStringToBytes(blockHashHex)._unsafeUnwrap(); // Safety: blockHashHex is known and can't error

const ethereumAddressResult = await eip712Signer.getSignerKey();

Expand Down