Add MiniMax M3 to OAuth fallback discovery#872
Conversation
Greptile SummaryAdds MiniMax M3 to OAuth fallback discovery while retaining the existing curated entries.
Confidence Score: 4/5The PR appears safe to merge, with a non-blocking gap in regression coverage for the existing MiniMax high-speed fallback. The production change is a localized curated-list addition, while the new test leaves removal of tests/oauth-model-discovery.test.ts Important Files Changed
Reviews (1): Last reviewed commit: "Add MiniMax M3 OAuth fallback" | Re-trigger Greptile |
| expect(result.status).toBe("ok"); | ||
| expect(result.models).toContain("MiniMax-M3"); | ||
| expect(result.models).toContain("MiniMax-M2.7"); | ||
| }); |
There was a problem hiding this comment.
High-speed fallback remains untested
The Python-failure regression asserts MiniMax-M3 and MiniMax-M2.7 but omits the preserved MiniMax-M2.7-highspeed entry, so removing or renaming that existing fallback would leave the test passing.
Knowledge Base Used: Providers and Models
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Reason: Keep the current MiniMax models available when the live OAuth model query is unavailable.
Update the curated OAuth fallback list to include
MiniMax-M3while preserving the existing model entries. Add regression coverage for the Python discovery failure path.Checks:
npm exec vitest run tests/oauth-model-discovery.test.tsnpm run typechecknpm exec prettier -- --check src/main/model-discovery.ts tests/oauth-model-discovery.test.tsnpm exec eslint -- src/main/model-discovery.ts tests/oauth-model-discovery.test.ts