Skip to content

Add MiniMax M3 to OAuth fallback discovery#872

Open
octo-patch wants to merge 1 commit into
fathah:mainfrom
octo-patch:octo/20260723-provider-add-recvoSyZViLyQh
Open

Add MiniMax M3 to OAuth fallback discovery#872
octo-patch wants to merge 1 commit into
fathah:mainfrom
octo-patch:octo/20260723-provider-add-recvoSyZViLyQh

Conversation

@octo-patch

Copy link
Copy Markdown

Reason: Keep the current MiniMax models available when the live OAuth model query is unavailable.

Update the curated OAuth fallback list to include MiniMax-M3 while preserving the existing model entries. Add regression coverage for the Python discovery failure path.

Checks:

  • npm exec vitest run tests/oauth-model-discovery.test.ts
  • npm run typecheck
  • npm exec prettier -- --check src/main/model-discovery.ts tests/oauth-model-discovery.test.ts
  • npm exec eslint -- src/main/model-discovery.ts tests/oauth-model-discovery.test.ts

@greptile-apps

greptile-apps Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Adds MiniMax M3 to OAuth fallback discovery while retaining the existing curated entries.

  • Extends the minimax-oauth fallback model list with MiniMax-M3.
  • Adds regression coverage for MiniMax discovery when the Python helper fails.

Confidence Score: 4/5

The PR appears safe to merge, with a non-blocking gap in regression coverage for the existing MiniMax high-speed fallback.

The production change is a localized curated-list addition, while the new test leaves removal of MiniMax-M2.7-highspeed undetected.

tests/oauth-model-discovery.test.ts

Important Files Changed

Filename Overview
src/main/model-discovery.ts Adds MiniMax-M3 to the existing MiniMax OAuth fallback list without altering discovery behavior.
tests/oauth-model-discovery.test.ts Covers the MiniMax Python-failure fallback, but does not assert preservation of the existing high-speed model entry.

Reviews (1): Last reviewed commit: "Add MiniMax M3 OAuth fallback" | Re-trigger Greptile

expect(result.status).toBe("ok");
expect(result.models).toContain("MiniMax-M3");
expect(result.models).toContain("MiniMax-M2.7");
});

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 High-speed fallback remains untested

The Python-failure regression asserts MiniMax-M3 and MiniMax-M2.7 but omits the preserved MiniMax-M2.7-highspeed entry, so removing or renaming that existing fallback would leave the test passing.

Knowledge Base Used: Providers and Models

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant