Skip to content

Add MiniMax M3 to OAuth fallback discovery #872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
octo-patch wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −1
Open

Add MiniMax M3 to OAuth fallback discovery #872

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/model-discovery.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ const OAUTH_PROVIDER_CURATED: Record<string, string[]> = {
"gemini-3-pro-preview",
"gemini-3-flash-preview",
],
"minimax-oauth": ["MiniMax-M2.7", "MiniMax-M2.7-highspeed"],
"minimax-oauth": ["MiniMax-M3", "MiniMax-M2.7", "MiniMax-M2.7-highspeed"],
"qwen-oauth": [],
};

Expand Down
13 changes: 13 additions & 0 deletions tests/oauth-model-discovery.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,19 @@ describe("OAuth provider model discovery", () => {
expect(result.models).toContain("gemini-3-pro-preview");
});

it("includes the current MiniMax models when the Python call fails", async () => {
behavior.err = new Error("python: command not found");
const result = await discoverProviderModels(
"minimax-oauth",
undefined,
undefined,
undefined,
);
expect(result.status).toBe("ok");
expect(result.models).toContain("MiniMax-M3");
expect(result.models).toContain("MiniMax-M2.7");
});

@greptile-apps greptile-apps Bot Jul 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 High-speed fallback remains untested

The Python-failure regression asserts MiniMax-M3 and MiniMax-M2.7 but omits the preserved MiniMax-M2.7-highspeed entry, so removing or renaming that existing fallback would leave the test passing.

Knowledge Base Used: Providers and Models

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!


it("caches the result so a second call skips the Python spawn", async () => {
behavior.stdout = '["gpt-5.5"]';
const first = await discoverProviderModels(
Expand Down