Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New shell login setup #364

Closed
wants to merge 9 commits into from
Closed

New shell login setup #364

wants to merge 9 commits into from

Conversation

mwilde345
Copy link
Member

@mwilde345 mwilde345 commented Sep 23, 2024 •
edited
Loading

Ticket(s): FE-5879

  • Basic interface to call frontdoor auth code, token and session endpoints.
  • Only works locally as frontdoor only knows about the local client id.
  • Fails if new_session_tokens is not turned on

Out of Scope

In another PR i'll break some of this out to a new frontdoor client where I can add unit tests and other methods like refresh session

Screen.Recording.2024-09-23.at.1.27.00.PM.mov

@mwilde345 mwilde345 marked this pull request as ready for review September 23, 2024 17:30
@mwilde345 mwilde345 changed the title login poc New shell login setup Sep 23, 2024
macmv
macmv reviewed Sep 23, 2024
View reviewed changes
src/lib/auth/oauth-client.ts Outdated Show resolved Hide resolved
macmv
macmv reviewed Sep 23, 2024
View reviewed changes
Copy link
Contributor

@macmv macmv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, lgtm. i don't have much context on the oauth flow, so it'd be best to get someone else's approval too.

cleve-fauna
cleve-fauna reviewed Sep 24, 2024
View reviewed changes
src/commands/login.ts Outdated Show resolved Hide resolved
@mwilde345 @cleve-fauna
Update src/commands/login.ts
af4ad7c 
Co-authored-by: Cleve Stuart <[email protected]>
cleve-fauna
cleve-fauna approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@cleve-fauna cleve-fauna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly questions for the future.

A couple minor suggestions.

src/commands/login.ts Show resolved Hide resolved
src/commands/login.ts Outdated Show resolved Hide resolved
src/lib/auth/oauth-client.ts Show resolved Hide resolved
src/lib/auth/oauth-client.ts Outdated Show resolved Hide resolved
@mwilde345 mwilde345 mentioned this pull request Sep 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macmv macmv macmv left review comments

@cleve-fauna cleve-fauna cleve-fauna approved these changes

@henryfauna henryfauna Awaiting requested review from henryfauna

@echo-bravo-yahoo echo-bravo-yahoo Awaiting requested review from echo-bravo-yahoo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mwilde345 @echo-bravo-yahoo @macmv @cleve-fauna