Add colors #365
Merged
Add colors #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macmv
commented
Sep 24, 2024
macmv
commented
Sep 24, 2024
macmv
force-pushed
the
request-colors
branch
from
c62c003
to
eb61af4
Compare
freels
reviewed
Sep 25, 2024
macmv
force-pushed
the
request-colors
branch
from
a73b260
to
1c76315
Compare
freels
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket(s): ENG-6785
Core is adding support for colors as query parameters from schema endpoints. This PR adds colors to all the schema commands.
This uses a library to check if colors are enabled, which will detect things like if we're in a TTY, and it'll detect common CI environments for us.
Additionally, new global
--colorand--no-colorflags have been added. The librarysupports-colorwill parsesys.argv, and enable/disable colors accordingly. Because oclif makes it difficult to check if an optional flag is set, I'm going to leave this as-is, but it is currently quite brittle.Testing has been manual, oclif doesn't provide a way to unit test with colors.