Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Farewell, Interaction]: Step 2 of removing the Interaction class #4189

Merged
merged 10 commits into from
Mar 21, 2021
Merged

[Farewell, Interaction]: Step 2 of removing the Interaction class #4189

merged 10 commits into from
Mar 21, 2021

Conversation

d2dyno1
Copy link
Member

@d2dyno1 d2dyno1 commented Mar 20, 2021 •
edited
Loading

Continuation of #4016
For #4180

This is the final part of [Farewell, Interaction]. This PR removes the Interaction class

@d2dyno1 d2dyno1 marked this pull request as draft March 20, 2021 21:23
@d2dyno1 d2dyno1 changed the title [Farewell, Interaction]: Step 1 of removing the Interaction class [Farewell, Interaction]: Step 2 of removing the Interaction class Mar 20, 2021
@d2dyno1 d2dyno1 marked this pull request as ready for review March 21, 2021 11:56
@d2dyno1
Copy link
Member Author

d2dyno1 commented Mar 21, 2021

@yaichenbaum Ready!

d2dyno1
d2dyno1 commented Mar 21, 2021
View reviewed changes
Files/Files.csproj
@@ -453,7 +453,6 @@
<Compile Include="ViewModels\InteractionViewModel.cs" />
<Compile Include="ViewModels\DirectoryPropertiesViewModel.cs" />
<Compile Include="ViewModels\SelectedItemsPropertiesViewModel.cs" />
<Compile Include="Interacts\Interaction.cs" />
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FINALLY!!!

@yaira2 yaira2 requested a review from gave92 March 21, 2021 13:55
@yaira2 yaira2 requested a review from tsvietOK March 21, 2021 14:23
gave92
gave92 previously approved these changes Mar 21, 2021
View reviewed changes
Copy link
Member

@gave92 gave92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I like these changes quite a bit.

@gave92 gave92 self-requested a review March 21, 2021 18:31
@gave92
Copy link
Member

gave92 commented Mar 21, 2021 •
edited
Loading

Wait.. could you check if jump string is still working? I think some timer got removed and now jumpstring does not consider more that one character.

@gave92 gave92 dismissed their stale review March 21, 2021 18:38

Found small issue with Jump String

@d2dyno1
Copy link
Member Author

d2dyno1 commented Mar 21, 2021

@gave92 I've re-added jumpTimer in 232ec15

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Mar 21, 2021
@yaira2 yaira2 merged commit 2159b62 into files-community:main Mar 21, 2021
@d2dyno1
Copy link
Member Author

d2dyno1 commented Mar 21, 2021

We did it! Interaction is no more!

@d2dyno1
Copy link
Member Author

d2dyno1 commented Mar 21, 2021

OK, I'll push a quick fix in a moment! @gave92

This was referenced Mar 21, 2021
Merged
Closed
@winston-de winston-de mentioned this pull request Mar 22, 2021
Closed
@d2dyno1 d2dyno1 deleted the farewell_interaction branch April 5, 2021 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gave92 gave92 gave92 approved these changes

@yaira2 yaira2 yaira2 approved these changes

@tsvietOK tsvietOK Awaiting requested review from tsvietOK

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@d2dyno1 @gave92 @yaira2