Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUITING.md doc #573

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Conversation

MCarlomagno
Copy link
Contributor

@MCarlomagno MCarlomagno commented Oct 4, 2023

πŸ“ Summary

Fix deprecated dependency versions in documentation. See #572

β›± Motivation and Context

πŸ“š References


βœ… I have run these commands

  • make lint
  • make test-race
  • go mod tidy

CONTRIBUTING.md Outdated
go install honnef.co/go/tools/cmd/staticcheck@v0.3.0
go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.49.0
go install honnef.co/go/tools/cmd/staticcheck@v0.4.0
go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.51.0
Copy link
Collaborator

@metachris metachris Oct 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks!

CI uses 1.51.2: https://github.com/flashbots/mev-boost/blob/develop/.github/workflows/lint.yml

not sure how to best unify

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! just updated the PR using same CI dependencies

metachris
metachris previously approved these changes Oct 5, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #573 (92004d8) into develop (83a69d8) will increase coverage by 0.27%.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff             @@
##           develop     #573      +/-   ##
===========================================
+ Coverage    69.69%   69.96%   +0.27%     
===========================================
  Files            7        7              
  Lines         1102     1102              
===========================================
+ Hits           768      771       +3     
+ Misses         288      287       -1     
+ Partials        46       44       -2     
Flag Coverage Ξ”
unittests 69.96% <ΓΈ> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@metachris metachris merged commit 9fef9b4 into flashbots:develop Oct 19, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants