Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CONTRIBUITING.md doc #573

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Update CONTRIBUITING.md doc #573

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92004d8
Update CONTRIBUITING.md doc
MCarlomagno Oct 4, 2023
8c61c61
match docs dependencies with ci version
MCarlomagno Oct 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ Install a few dev dependencies for `make lint`:
```bash
go install github.com/mgechev/[email protected]
go install mvdan.cc/[email protected]
go install honnef.co/go/tools/cmd/staticcheck@v0.3.0
go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.49.0
go install honnef.co/go/tools/cmd/staticcheck@v0.4.0
go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.51.0
Copy link
Collaborator

@metachris metachris Oct 5, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks!

CI uses 1.51.2: https://github.com/flashbots/mev-boost/blob/develop/.github/workflows/lint.yml

not sure how to best unify

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! just updated the PR using same CI dependencies

```

Look at the [README for instructions to install the dependencies and build `mev-boost`](README.md#installing)
Expand Down
Loading