Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Node v18 for build #1285

Merged
merged 1 commit into from
Nov 13, 2022
+24 −17
Merged

Support Node v18 for build #1285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,27 +102,27 @@ Translations can now be provided over at [transifex](https://www.transifex.com/f
#### Setting up a dev environment

- Clone this repository.
- Install node.js v16 and npm 8
- In the root of your floccus repo, run `npm install && npm install -g gulp`
- Run `gulp` to build
- Find out more on how to develop browser extensions here: <https://extensionworkshop.com/>
- Install the [latest LTS version of node.js](https://nodejs.org/en/download/).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just update this to v18 instead of the generic "latest lts"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My idea was: with "latest LTS" one does not have to update the README again when switching from v18 to v20.

And I thought it makes sense to keep the project aligned with the current active LTS version of nodejs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, should the actions in .github/workflows/ be updated to use node v18?

- In the root of your floccus repo, run `npm install`.
- Run `npm run build` to build.
- Find out more on how to develop browser extensions here: <https://extensionworkshop.com/>.

For building the android app you'll need Android Studio

- Open the android/ folder in Android studio and build the App like any other Android app.
- `gulp` and `gulp watch` will push changes to android/ as necessary
- Open the `android/` folder in Android studio and build the App like any other Android app.
- `npm run build` and `npm run watch` will push changes to `android/` as necessary.

#### Building

- `gulp`
- `npm run build`

Run the following to automatically compile changes as you make them:

- `gulp watch`
- `npm run watch`

#### Releasing

- `gulp release`
- `npm run build-release`

## Backers

Expand All @@ -147,5 +147,5 @@ Support this project by becoming a sponsor. Your logo will show up here with a l

## License

(c) Marcel Klehr
(c) Marcel Klehr
MPL-2.0 (see LICENSE.txt)
11 changes: 9 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
"scripts": {
"build": "gulp",
"build-release": "gulp release",
"watch": "gulp watch",
"test": "node --unhandled-rejections=strict test/selenium-runner.js"
},
"repository": {
Expand Down Expand Up @@ -44,7 +45,6 @@
"eslint-plugin-standard": "^4.1.0",
"eslint-plugin-vue": "9.x.x",
"execa": "^6.1.0",
"fibers": "^5.0.0",
"file-loader": "^6.2.0",
"gist-client": "^1.1.1",
"gulp": "^4",
Expand Down
8 changes: 4 additions & 4 deletions webpack.common.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@ module.exports = {
),
options: path.join(__dirname, 'src', 'entries', 'options.js'),
test: path.join(__dirname, 'src', 'entries', 'test.js'),
native: path.join(__dirname, 'src', 'entries', 'native.js')
native: path.join(__dirname, 'src', 'entries', 'native.js'),
},
optimization: {
splitChunks: { chunks: 'async' }
splitChunks: { chunks: 'async' },
},
output: {
path: path.resolve(__dirname, 'dist', 'js'),
Expand Down Expand Up @@ -45,7 +45,7 @@ module.exports = {
options: {
implementation: require('sass'),
sassOptions: {
fiber: require('fibers'),
fiber: false,
indentedSyntax: true, // optional
},
},
Expand Down Expand Up @@ -73,7 +73,7 @@ module.exports = {
'@babel/preset-env',
{
useBuiltIns: 'usage',
corejs: {version: '3.19', proposals: true},
corejs: { version: '3.19', proposals: true },
shippedProposals: true,
},
],
Expand Down