-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Help with ROADMAP - Site translation #1
Comments
Hi delthia, thanks a lot for your offer to help translating and maintaining this site, really appreciate it! I had a look at your fork and you are definitely going in the right direction. I am completely fine with you adding the language switcher and helping with some of the roadmap items, this helps a lot! :) Some thoughts about the localization management: Hugo allows to have multiple configs in a config dir. Wouldn't it make sense to have one base config for the normal config stuff and then for each language a specific config file (e.g. As for the translation of the content pages I am unsure, your format looks ok to me, however I've also seen the Just some thoughts, if you have some other idea or approach I am open to them too :) |
Hi,
That also makes sense to me, so I'll get that going too. Now for a question: Should I change the index.html contents to all be variables? I'll also try to get going with the language selector. I'll try a dropdown made in html and css (I would like to avoid js if possible). With that, I'll keep track of my progress here. Thanks
|
Yep I think it is best to use the variables approach for all html files, and use the translate file directly approach for markdown content pages.
If you should need a little bit of JS it isn't too much of a deal, as long as no third-party JS libs are used. But a HTML/CSS-only dropdown would definitely be cool, it it is possible without too much issues. |
Hello again,
I've fixed that
I've experimented with making it using the checkbox trick in css. For now, the dropdown part works, minus a few (quite a few, really) styling issues. I now have to get working to make it change to the translated version of the page the user is in, not just redirect to the translated frontpage, who it now does, and to make the selected language, either be marked in the dropdown, or just not appearing, but I'm trying to figure that out in hugo's templating system. I've positioned it at the left of the 'visit github repo' button, but it should be a problem moving it elsewhere. I thought of putting it on the footer, which would work for the frontpage, but I'm unsure how practical it would be on longer pages, like the privacy policy. The changes are live on my fork and on f.delthia.com |
Do you mean the trick where you have a hidden checkbox at the beginning of the document and you utilize the
Tbh I think left of the Github repo link is best. What I had in mind for the future was to replace the "Visit GitHub repo" link in the header with just a clickable GitHub icon. This would save valuable space, especially on mobile browsers. |
Correct. There is a hidden checkbox just beside the label, and I use
Then I'll leave it there. Putting a GitHub icon instead of the text can be done whenever you feel like it, its not a problem for me to change that if you would like so. |
Just tested out your changes and it is going in a really good direction!
As I thought, this is a very neat trick which can be utilized in many ways to have cool features normally not possible without JS (had quite a bit of fun playing around with this functionality in my early days).
This is something which we can change easily later on, for now I think letting the link stay in place is best. I'll let you continue work on this and respond to questions/give feedback when needed :) |
Hi, PS. I have done some simple styling on the dropdown, and I think is mostly ok, but definitely not perfect. I haven't animated the opening and closing, as I tried but wasn't able te figure that out. |
Hi, |
No worries, currently my time schedule is also pretty packed so I fully understand your situation. Just take your time and ping me once you say it is ready for review again :) |
Hi,
I'm willing to help with creating and maintaining this site, as I don't know kotlin, therefore I can't help with the main project much (appart from translations and such), and think that I can help here, people who also would be willing to help and know kotlin, could do that with the main project, prioritizing it.
Having this in mind, I started by translating the website and getting it ready for other language's translations to be added, by putting all translatable terms from the page in the config. For now I haven't made a language switcher, but my changes are contained on my fork, and the changes can be previewed in this subdomain by going to any page, and adding
/es
right after the domain name and before the path (I put the preview in a subdomain of mine just because that was less work than making it work under a subpath in the github pages domain).If you think that I'm going in the right direction and would like for me to continue with adding the language switcher and/or other task on the website's roadmap, as I'm completely open in helping with that.
Thanks
The text was updated successfully, but these errors were encountered: