Fix Internal API usage of IconManager #181
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced internal IconManager.loadRasterizedIcon with public IconLoader.getIcon. Removed auto-generated warning from DartIcons.java as the file is now manually maintained. This resolves 1 internal API usage warning in the plugin verification report.
pq
reviewed
Jan 14, 2026
| public final class DartIcons { | ||
| private static @NotNull Icon load(@NotNull String expUIPath, @NotNull String path, int cacheKey, int flags) { | ||
| return IconManager.getInstance().loadRasterizedIcon(path, expUIPath, DartIcons.class.getClassLoader(), cacheKey, flags); | ||
| return com.intellij.openapi.util.IconLoader.getIcon(path, DartIcons.class); |
Collaborator
There was a problem hiding this comment.
We generally don't package-qualify symbols. Can you turn this into a normal import for consistency? (And perhaps update your prompt?)
Also: are there ramifications for no longer using a cacheKey? It's probably OK, just curious. Also: since we're not using cacheKey and flags after this change, can we update this method signature to remove them and then update all the calls sites?
Collaborator
I'm not seeing where this happens here. Or maybe I don't know what you mean? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced internal IconManager.loadRasterizedIcon with public IconLoader.getIcon. Removed auto-generated warning from DartIcons.java as the file is now manually maintained. This resolves 1 internal API usage warning in the plugin verification report.