Skip to content

Fix Internal API usage of IconManager #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jwren wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Internal API usage of IconManager #181

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions third_party/gen/icons/DartIcons.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// Copyright 2000-2020 JetBrains s.r.o. Use of this source code is governed by the Apache 2.0 license that can be found in the LICENSE file.
package icons;

import com.intellij.ui.IconManager;

import org.jetbrains.annotations.NotNull;

import javax.swing.*;
Expand All @@ -12,7 +12,7 @@
*/
public final class DartIcons {
private static @NotNull Icon load(@NotNull String expUIPath, @NotNull String path, int cacheKey, int flags) {
return IconManager.getInstance().loadRasterizedIcon(path, expUIPath, DartIcons.class.getClassLoader(), cacheKey, flags);
return com.intellij.openapi.util.IconLoader.getIcon(path, DartIcons.class);
Copy link
Collaborator

@pq pq Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We generally don't package-qualify symbols. Can you turn this into a normal import for consistency? (And perhaps update your prompt?)

Also: are there ramifications for no longer using a cacheKey? It's probably OK, just curious. Also: since we're not using cacheKey and flags after this change, can we update this method signature to remove them and then update all the calls sites?

}
/** 13x13 */ public static final @NotNull Icon Dart_13 = load("icons/expui/toolWindowDart.svg", "icons/dart_13.svg", 650580758, 2);
/** 16x16 */ public static final @NotNull Icon Dart_16 = load("icons/expui/dart.svg", "icons/dart_16.svg", 1655941025, 2);
Expand Down
Loading