Fix Internal API usage of XBreakpointBase #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed internal XBreakpointBase.fireBreakpointChanged call. Added comment explaining that the platform handles change notifications automatically. This resolves 2 internal API usage warnings in the plugin verification report.
Member
|
How can we test that this works the same as before? Would it be by checking if an exception can still trigger a breakpoint? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed internal XBreakpointBase.fireBreakpointChanged call. Added comment explaining that the platform handles change notifications automatically. This resolves 2 internal API usage warnings in the plugin verification report.