Skip to content

Fix Internal API usage of XBreakpointBase #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jwren wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Internal API usage of XBreakpointBase #182

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 13 additions & 9 deletions ...d_party/src/main/java/com/jetbrains/lang/dart/ide/runner/DartExceptionBreakpointType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
import com.intellij.xdebugger.breakpoints.XBreakpoint;
import com.intellij.xdebugger.breakpoints.XBreakpointType;
import com.intellij.xdebugger.breakpoints.ui.XBreakpointCustomPropertiesPanel;
import com.intellij.xdebugger.impl.breakpoints.XBreakpointBase;

import com.jetbrains.lang.dart.DartBundle;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable;
Expand All @@ -17,7 +17,7 @@
import java.awt.*;

public final class DartExceptionBreakpointType
extends XBreakpointType<XBreakpoint<DartExceptionBreakpointProperties>, DartExceptionBreakpointProperties> {
extends XBreakpointType<XBreakpoint<DartExceptionBreakpointProperties>, DartExceptionBreakpointProperties> {

public DartExceptionBreakpointType() {
super("dart-exception", DartBundle.message("breakpoint.type.title.dart.exception.breakpoint"));
Expand Down Expand Up @@ -49,19 +49,22 @@ public String getDisplayText(XBreakpoint<DartExceptionBreakpointProperties> brea
}

@Override
public XBreakpoint<DartExceptionBreakpointProperties> createDefaultBreakpoint(@NotNull XBreakpointCreator<DartExceptionBreakpointProperties> creator) {
final XBreakpoint<DartExceptionBreakpointProperties> breakpoint = creator.createBreakpoint(new DartExceptionBreakpointProperties());
public XBreakpoint<DartExceptionBreakpointProperties> createDefaultBreakpoint(
@NotNull XBreakpointCreator<DartExceptionBreakpointProperties> creator) {
final XBreakpoint<DartExceptionBreakpointProperties> breakpoint = creator
.createBreakpoint(new DartExceptionBreakpointProperties());
breakpoint.setEnabled(true);
return breakpoint;
}

@Override
public @Nullable XBreakpointCustomPropertiesPanel<XBreakpoint<DartExceptionBreakpointProperties>> createCustomPropertiesPanel(final @NotNull Project project) {
public @Nullable XBreakpointCustomPropertiesPanel<XBreakpoint<DartExceptionBreakpointProperties>> createCustomPropertiesPanel(
final @NotNull Project project) {
return new DartExceptionBreakpointPropertiesPanel();
}

private static class DartExceptionBreakpointPropertiesPanel
extends XBreakpointCustomPropertiesPanel<XBreakpoint<DartExceptionBreakpointProperties>> {
extends XBreakpointCustomPropertiesPanel<XBreakpoint<DartExceptionBreakpointProperties>> {

private JBRadioButton myBreakOnUncaughtExceptions;
private JBRadioButton myBreakOnAllExceptions;
Expand Down Expand Up @@ -89,16 +92,17 @@ public void saveTo(final @NotNull XBreakpoint<DartExceptionBreakpointProperties>
final boolean newValue = myBreakOnAllExceptions.isSelected();
if (oldValue != newValue) {
breakpoint.getProperties().setBreakOnAllExceptions(newValue);
((XBreakpointBase<?, ?, ?>)breakpoint).fireBreakpointChanged();
// 'fireBreakpointChanged' is an internal API. The platform handles change
// notifications
// automatically after 'saveTo' returns, so explicit firing is not needed.
}
}

@Override
public void loadFrom(final @NotNull XBreakpoint<DartExceptionBreakpointProperties> breakpoint) {
if (breakpoint.getProperties().isBreakOnAllExceptions()) {
myBreakOnAllExceptions.setSelected(true);
}
else {
} else {
myBreakOnUncaughtExceptions.setSelected(true);
}
}
Expand Down
Loading