Skip to content

spm support via google_maps_flutter_ios_sdk9#11693

Closed
qeepcologne wants to merge 3 commits into
flutter:mainfrom
qeepcologne:qeep-drop-google-maps-ios-dep
Closed

spm support via google_maps_flutter_ios_sdk9#11693
qeepcologne wants to merge 3 commits into
flutter:mainfrom
qeepcologne:qeep-drop-google-maps-ios-dep

Conversation

@qeepcologne
Copy link
Copy Markdown

change depdendency to google_maps_flutter_ios_sdk9 to support swift package manager.
requires ios15.

@google-cla
Copy link
Copy Markdown

google-cla Bot commented May 12, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the google_maps_flutter package to use google_maps_flutter_ios_sdk9 as the default iOS implementation. The reviewer noted that this change increases the minimum iOS requirement and requires a major version bump to comply with semantic versioning. Additionally, the trailing newline in pubspec.yaml should be restored for style consistency.

default_package: google_maps_flutter_android
ios:
default_package: google_maps_flutter_ios
default_package: google_maps_flutter_ios_sdk9
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Switching the default iOS implementation to google_maps_flutter_ios_sdk9 is a breaking change because it increases the minimum iOS requirement to 15 (as noted in the PR description). According to the repository's contribution guidelines regarding semantic versioning, this change requires a major version bump for the google_maps_flutter package to avoid breaking existing users on older iOS versions.

References
  1. The flutter/packages contribution guide (referenced in the repository style guide) requires following semantic versioning, which mandates a major version bump for breaking changes such as increasing minimum platform requirements. (link)

# The example deliberately includes limited-use secrets.
false_secrets:
- /example/web/index.html
- /example/web/index.html No newline at end of file
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The trailing newline at the end of the file has been removed. It is a best practice to maintain a single newline at the end of files to ensure compatibility with POSIX tools and to avoid unnecessary diff noise in future changes.

  - /example/web/index.html
References
  1. Code should follow relevant style guides and use the correct auto-formatter, which typically enforces a trailing newline at the end of the file. (link)

@stuartmorgan-g
Copy link
Copy Markdown
Collaborator

Thanks for the contribution, but PRs need to follow our process. If you are interested in contributing, please open a new PR that follows the PR checklist instead of removing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants