Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/google_maps_flutter/google_maps_flutter/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,15 @@ flutter:
android:
default_package: google_maps_flutter_android
ios:
default_package: google_maps_flutter_ios
default_package: google_maps_flutter_ios_sdk9
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Switching the default iOS implementation to google_maps_flutter_ios_sdk9 is a breaking change because it increases the minimum iOS requirement to 15 (as noted in the PR description). According to the repository's contribution guidelines regarding semantic versioning, this change requires a major version bump for the google_maps_flutter package to avoid breaking existing users on older iOS versions.

References
  1. The flutter/packages contribution guide (referenced in the repository style guide) requires following semantic versioning, which mandates a major version bump for breaking changes such as increasing minimum platform requirements. (link)

web:
default_package: google_maps_flutter_web

dependencies:
flutter:
sdk: flutter
google_maps_flutter_android: ^2.19.1
google_maps_flutter_ios: ^2.18.0
google_maps_flutter_ios_sdk9: ^2.18.1
google_maps_flutter_platform_interface: ^2.15.0
google_maps_flutter_web: ^0.6.2

Expand All @@ -40,4 +40,4 @@ topics:

# The example deliberately includes limited-use secrets.
false_secrets:
- /example/web/index.html
- /example/web/index.html
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The trailing newline at the end of the file has been removed. It is a best practice to maintain a single newline at the end of files to ensure compatibility with POSIX tools and to avoid unnecessary diff noise in future changes.

  - /example/web/index.html
References
  1. Code should follow relevant style guides and use the correct auto-formatter, which typically enforces a trailing newline at the end of the file. (link)